Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: About tab #132

Merged
merged 5 commits into from Aug 22, 2019

Conversation

@ryanio
Copy link
Collaborator

commented Aug 22, 2019

What does it do?

  • Adds an About tab as the first tab on plugins
  • Renames Details tab to Metadata

To be paired with ethereum/grid#426


Screenshots:

Screen Shot 2019-08-21 at 9 47 21 PM

Screen Shot 2019-08-21 at 8 09 46 PM

Screen Shot 2019-08-21 at 8 22 15 PM

Screen Shot 2019-08-21 at 8 22 21 PM


Closes ethereum/grid#422

@ryanio ryanio referenced this pull request Aug 22, 2019
Copy link
Collaborator

left a comment

When on the Settings tab of one plugin, navigating to another plugin produces this error:
Screen Shot 2019-08-22 at 7 40 13 AM

You've added some logic to provide a 'backup plan' for the case where there is no About tab. Haven't dug in too much, but I think this is an edge case in that new logic. Before remedying that edge case, my question is why not just require the About data?

@ryanio

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2019

When on the Settings tab of one plugin, navigating to another plugin produces this error:

thanks I will fix

You've added some logic to provide a 'backup plan' for the case where there is no About tab. Haven't dug in too much, but I think this is an edge case in that new logic. Before remedying that edge case, my question is why not just require the About data?

good idea, i was trying to be clever but hiding/showing tabs proves to be tricky, so i will just show 'No about data.' text on the tab if there is no data. It will encourage plugin developers to also fill it out

@ryanio ryanio merged commit 8c37676 into dev Aug 22, 2019
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ryanio added a commit that referenced this pull request Aug 26, 2019
* fix: plugin refactor v1 (#121)
* fix: refactor plugin directory
* fix: refactor plugin redux store
* fix: refactor plugin actions and service (#122)
* fix: update action names
* fix: refactor pluginService
* fix: plugin name refactor v3 (#123)
* chore: Renames `ClientConfig` and inside `client` references to `PluginConfig` and `plugin` (#124)
* chore: refactor client PluginService funcs into ClientService (#125)
* chore: reafactor client PluginService funcs into ClientService
* fix: clear peer count interval properly
* chore: refactor service to plugin (#127)
* chore: refactor service to plugin
* chore: refactor PluginConfig and Terminal
* chore: update README with latest links/screenshot (#128)
* fix: disable FlagPreview on running (#129)
* chore: remove stale files (#130)
* feat: Reinstate Node Info (#126)
* chore: reinstate NodeInfo, and show on plugin.type === 'client'
* chore: add more margin to NodeInfo dot
* chore: reafactor client PluginService funcs into ClientService
* fix: clear peer count interval properly
* chore: switch syncing from subscription to polling
* style: lighter sync mode pill background color
* chore: clear sync data after starting block subscription
* chore: add reducer test for PLUGIN:CLEAR_SYNCING
* style: tone down red NodeInfoDot color
* feat: About tab (#132)
* feat: about tab for plugins
* fix: fix warning by converting DynamicConfigFormItem value to string
* feat: allow plugins to specify their own dependencies
* fix: show message if no about data (instead of trying to hide tab)
* fix: cannot read property toString of undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.