Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: About tab #132
marcgarreau left a comment
You've added some logic to provide a 'backup plan' for the case where there is no About tab. Haven't dug in too much, but I think this is an edge case in that new logic. Before remedying that edge case, my question is why not just require the About data?
thanks I will fix
good idea, i was trying to be clever but hiding/showing tabs proves to be tricky, so i will just show 'No about data.' text on the tab if there is no data. It will encourage plugin developers to also fill it out
* fix: plugin refactor v1 (#121) * fix: refactor plugin directory * fix: refactor plugin redux store * fix: refactor plugin actions and service (#122) * fix: update action names * fix: refactor pluginService * fix: plugin name refactor v3 (#123) * chore: Renames `ClientConfig` and inside `client` references to `PluginConfig` and `plugin` (#124) * chore: refactor client PluginService funcs into ClientService (#125) * chore: reafactor client PluginService funcs into ClientService * fix: clear peer count interval properly * chore: refactor service to plugin (#127) * chore: refactor service to plugin * chore: refactor PluginConfig and Terminal * chore: update README with latest links/screenshot (#128) * fix: disable FlagPreview on running (#129) * chore: remove stale files (#130) * feat: Reinstate Node Info (#126) * chore: reinstate NodeInfo, and show on plugin.type === 'client' * chore: add more margin to NodeInfo dot * chore: reafactor client PluginService funcs into ClientService * fix: clear peer count interval properly * chore: switch syncing from subscription to polling * style: lighter sync mode pill background color * chore: clear sync data after starting block subscription * chore: add reducer test for PLUGIN:CLEAR_SYNCING * style: tone down red NodeInfoDot color * feat: About tab (#132) * feat: about tab for plugins * fix: fix warning by converting DynamicConfigFormItem value to string * feat: allow plugins to specify their own dependencies * fix: show message if no about data (instead of trying to hide tab) * fix: cannot read property toString of undefined