Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: omits required settings from form UI #136

Merged
merged 1 commit into from Aug 29, 2019

Conversation

@marcgarreau
Copy link
Collaborator

commented Aug 28, 2019

What does it do?

Introduces required flags. Half of closing ethereum/grid#442

Any helpful background information?

I like this solution because:
A) the plugin config code is a little verbose, but requires no changes to the complicated flag generation logic, and
B) users can still go wild and override the flags in the custom flag section

Note: assuming you have some stored values for Parity configs, you will likely have to toggle custom flags on and off to see the new ones appear.

Relevant screenshots?

Screen Shot 2019-08-28 at 4 17 39 PM

@ryanio
ryanio approved these changes Aug 28, 2019
Copy link
Collaborator

left a comment

LGTM 👍

@marcgarreau marcgarreau merged commit 4cb660b into dev Aug 29, 2019
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@marcgarreau marcgarreau deleted the required-flags branch Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.