Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clearPluginErrors for nano #139

Merged
merged 2 commits into from Sep 4, 2019

Conversation

@ryanio
Copy link
Collaborator

commented Aug 30, 2019

What does it do?

Fixes ethereum/grid#418

  • Dispatches clearPluginErrors on Terminal tab click or closing error.
  • Adds error count badge on Terminal tab.

Pairs with ethereum/grid#446

ezgif-3-fd8dcc88d419

…closing error. Also adds error count badge on Terminal tab
@marcgarreau

This comment has been minimized.

Copy link
Collaborator

commented Aug 30, 2019

This might be a good point to clean up the UX a bit by only displaying one at a time? The overlapping toasts have always looked pretty amateurish.

Copy link
Collaborator

left a comment

Clearing appears to work now, but maybe too well when going from nano to grid-ui. When you click on the error icon in nano, the errors are already gone in grid-ui, though you can read the terminal output to learn that a port is already in use, for example. Optimizing this can be done in a subsequent changeset.

@marcgarreau marcgarreau merged commit 189760e into dev Sep 4, 2019
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@marcgarreau marcgarreau deleted the clearPluginError branch Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.