Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use notistack #147

Merged
merged 7 commits into from Sep 10, 2019

Conversation

@ryanio
Copy link
Collaborator

commented Sep 9, 2019

What does it do?

Use notistack to stack snackbars so they don't overlap

Also uses new getErrors and dismissError(key) in grid: ethereum/grid#468

Also converts FlagPreview to use notistack (and incorporates #148)

Closes ethereum/grid#467
Closes ethereum/grid#466


Screen Shot 2019-09-09 at 5 14 27 PM

Screen Shot 2019-09-09 at 5 09 14 PM

ryanio added 2 commits Sep 9, 2019

@ryanio ryanio changed the title fix: don't clear errors on terminal load feat: use notistack Sep 9, 2019

@marcgarreau marcgarreau merged commit d0f5c24 into dev Sep 10, 2019

2 checks passed

Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details

@marcgarreau marcgarreau deleted the dontClearErrorsOnTerminalLoad branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.