Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use notistack #147

Merged
merged 7 commits into from Sep 10, 2019

fix: pass plugin name to clear errors

  • Loading branch information...
marcgarreau committed Sep 10, 2019
commit 2b80599e44f8a1081853dfaec3da0623775a7596
@@ -155,11 +155,8 @@ export const clearError = (plugin, key) => {
}
}

export const clearPluginErrors = plugin => {
return {
type: 'PLUGIN:ERROR:CLEAR_ALL',
payload: { pluginName: plugin.name }
}
export const clearPluginErrors = pluginName => {
return { type: 'PLUGIN:ERROR:CLEAR_ALL', payload: { pluginName } }
}

export const selectPlugin = (pluginName, tab) => {
@@ -59,7 +59,7 @@ class PluginService {
dispatch(addPluginError(plugin.name, error))
}
this.clearPluginErrorsListener = () => {
dispatch(clearPluginErrors(plugin))
dispatch(clearPluginErrors(plugin.name))
}
this.setAppBadgeListener = ({ appId, count }) => {
dispatch(setAppBadges(plugin, { [appId]: count }))
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.