Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: metadata rename #156

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@marcgarreau
Copy link
Collaborator

commented Oct 1, 2019

What does it do?

  • renames PluginView -> Metadata
  • hides author-related fields until logic implemented

Any helpful background information?

It's a bad look to display our maintained plugins as untrusted.

@ryanio
ryanio approved these changes Oct 1, 2019
Copy link
Collaborator

left a comment

Looks good, I know stuff on the eth pkg side needs more work but it's great, and I don't mind signing packages at all for the plugins I maintain. I hope we can get it working at some point.

@ryanio ryanio merged commit 70e01b6 into dev Oct 2, 2019
2 checks passed
2 checks passed
Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@marcgarreau marcgarreau deleted the metadata-rename branch Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.