Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Info #29

Merged
merged 40 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@ryanio
Copy link
Collaborator

ryanio commented Mar 5, 2019

Adds NodeInfo to GethConfig, along with geth state in redux. This branch relies on ethereum/grid#67

Screen Shot 2019-03-11 at 12 07 06 AM

New dependencies? What are they used for?

Adds classnames, moment, react-minimal-pie-chart for NodeInfoBox/Dot deps

Closes ethereum/grid#35, closes ethereum/grid#73, closes ethereum/grid#74, closes ethereum/grid#38, closes ethereum/grid#75

evertonfraga and others added some commits Mar 1, 2019

@ryanio ryanio marked this pull request as ready for review Mar 5, 2019

ryanio and others added some commits Mar 5, 2019

@ryanio ryanio referenced this pull request Mar 11, 2019

Closed

Fix: UX improvements #26

4 of 4 tasks complete

ryanio added some commits Mar 11, 2019

@marcgarreau
Copy link
Collaborator

marcgarreau left a comment

mock API needs updating to preserve the ability to run in a browser: TypeError: geth.on is not a function

@marcgarreau

This comment has been minimized.

Copy link
Collaborator

marcgarreau commented Mar 11, 2019

first render of mui input fields are missing the white background behind the label:
Screen Shot 2019-03-11 at 2 21 43 PM

ryanio added some commits Mar 11, 2019

@marcgarreau

This comment has been minimized.

Copy link
Collaborator

marcgarreau commented Mar 11, 2019

After clicking the toggle "off", the terminal appears to show the node shutting down successfully, but the UI doesnt reflect it in the toggle:
Screen Shot 2019-03-11 at 2 36 16 PM
Clicking the toggle again, the UI shows it turn off and then back on quickly, followed by a 💥:
Screen Shot 2019-03-11 at 2 42 41 PM

@ryanio

This comment has been minimized.

Copy link
Collaborator Author

ryanio commented Mar 11, 2019

ty, should be fixed in latest commit

Show resolved Hide resolved src/API/ReduxStore.js Outdated

marcgarreau added some commits Mar 13, 2019

@marcgarreau
Copy link
Collaborator

marcgarreau left a comment

Lots of small UX improvements on the horizon, but this looks like good foundation to build on.

@marcgarreau marcgarreau merged commit 735fd4f into master Mar 13, 2019

2 checks passed

Semantic Pull Request ready to be merged or rebased
Details
ci/circleci: build Your tests passed on CircleCI!
Details

@marcgarreau marcgarreau deleted the nodeInfo branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.