Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redux persist #32

Merged
merged 4 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@ryanio
Copy link
Collaborator

ryanio commented Mar 14, 2019

What does it do?

Adds redux-persist to persist the store

New dependencies? What are they used for?

redux-persist

Does it close any issues?

Closes ethereum/grid#23

ryanio added some commits Mar 14, 2019

fix: default null values for `release` and `config`. persist just `re…
…lease` and `config`. remove local state from ConfigForm and use redux state values
@marcgarreau

This comment has been minimized.

Copy link
Collaborator

marcgarreau commented Mar 15, 2019

Don't forget to manually test. Updating any of the settings clobbers the rest of the config data.
Screen Shot 2019-03-15 at 7 40 37 AM
Screen Shot 2019-03-15 at 7 40 13 AM

@marcgarreau
Copy link
Collaborator

marcgarreau left a comment

Nice! Implementation in the rootReducer came out clean. Working well on my end. :shipit:

const newConfig = { ...config, ipc }
this.setState({ config: newConfig })
dispatch(setConfig({ config: newConfig }))

This comment has been minimized.

@marcgarreau

marcgarreau Mar 15, 2019

Collaborator

nit: this batch of functions looks like good candidates to be DRYed up into a generalized function. can be implemented in a future PR.

@evertonfraga evertonfraga changed the base branch from master to dev Mar 17, 2019

@ryanio ryanio merged commit b6eeeee into dev Mar 18, 2019

1 check passed

Semantic Pull Request ready to be squashed
Details

@marcgarreau marcgarreau deleted the reduxpersist branch Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.