Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out of sync nano #458

Merged
merged 2 commits into from Sep 5, 2019

Conversation

@marcgarreau
Copy link
Collaborator

commented Sep 5, 2019

What does it do?

  • Fix for nano getting out of sync with grid-ui. Please review @ryanio as git blame indicates you added the function just a couple days ago.

Relevant screenshots?

before:
Screen Shot 2019-09-05 at 11 55 45 AM

@ryanio
ryanio approved these changes Sep 5, 2019
Copy link
Collaborator

left a comment

Sure I don't mind the throw, probably better api for the UIs on the receiving end. I just added the error object to it. Is there a way we can reliably produce a throw though, so we can see how the ui and nano reacts to it and if we need to make any changes?

@ryanio ryanio merged commit 3941233 into master Sep 5, 2019

4 checks passed

Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-mac Your tests passed on CircleCI!
Details
ci/circleci: build-win Your tests passed on CircleCI!
Details

@marcgarreau marcgarreau deleted the fix-nano-sync branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.