diff --git a/ethereum_clients/ControlledProcess.js b/ethereum_clients/ControlledProcess.js index 7b1aac39..67be9798 100644 --- a/ethereum_clients/ControlledProcess.js +++ b/ethereum_clients/ControlledProcess.js @@ -161,8 +161,6 @@ class ControlledProcess extends EventEmitter { } stop() { return new Promise((resolve, reject) => { - this.removeStateListeners() - // FIXME kill IPC ? or is it indirectly closed: onIpcEnd if (!this.proc || !this.isRunning) { resolve(this) diff --git a/ethereum_clients/Plugin.js b/ethereum_clients/Plugin.js index a56d8c0a..83adeef2 100644 --- a/ethereum_clients/Plugin.js +++ b/ethereum_clients/Plugin.js @@ -265,6 +265,7 @@ class Plugin extends EventEmitter { console.log( `Plugin ${this.name} (${packagePath}) about to start. Binary: ${binaryPath}` ) + try { this.process = new ControlledProcess( binaryPath, @@ -274,8 +275,10 @@ class Plugin extends EventEmitter { this.registerEventListeners(this.process, this) await this.process.start(flags) } catch (error) { - console.log('error start', error) + console.log(`Plugin Start Error: ${error}`) + throw new Error(`Plugin Start Error: ${error}`) } + return this.process } async stop() { diff --git a/yarn.lock b/yarn.lock index 07937f19..fc5579c9 100644 --- a/yarn.lock +++ b/yarn.lock @@ -396,10 +396,10 @@ universal-user-agent "^2.0.0" url-template "^2.0.8" -"@philipplgh/electron-app-manager@^0.50.0": - version "0.50.0" - resolved "https://registry.yarnpkg.com/@philipplgh/electron-app-manager/-/electron-app-manager-0.50.0.tgz#8a69083a55ccf7ad1cf241a1630253380bcbc003" - integrity sha512-ZVYez5UKGeAj2roeif0EZI8KphrvGRrDR/sgxWYphfqKZnXA7igmcKk9qYhKhD6HwC5SMjM1fOwnV18Hm7I8nQ== +"@philipplgh/electron-app-manager@^0.51.0": + version "0.51.0" + resolved "https://registry.yarnpkg.com/@philipplgh/electron-app-manager/-/electron-app-manager-0.51.0.tgz#a93494eaa04cf99dc534591d580398230d81e0cc" + integrity sha512-aFYg9i+GJ/o9sM18w/kqYeqGR1dojdcymwYRhXNgoBdua1phj23ZM1h9+VHZPX3WtOvIN9XHmvET9h3p7mqhRQ== dependencies: "@octokit/rest" "^16.27.0" electron-updater "4.1.2"