Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add plugin getErrors and dismissError(key) #468

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@ryanio
Copy link
Collaborator

commented Sep 9, 2019

What does it do?

Add getErrors and dismissError for plugins.

@ryanio ryanio changed the title fix: don't clear error on click feat: add plugin getErrors and dismissError(key) Sep 9, 2019

@ryanio ryanio referenced this pull request Sep 9, 2019
@marcgarreau
Copy link
Collaborator

left a comment

works well in manual testing - nicely done 👏

emitPluginError(error) {
this.emit('pluginError', {
message: error.toString(),
key: new Date().getTime() + Math.random()

This comment has been minimized.

Copy link
@marcgarreau

marcgarreau Sep 10, 2019

Collaborator

were you getting duplicate keys without the Math.random?

This comment has been minimized.

Copy link
@ryanio

ryanio Sep 10, 2019

Author Collaborator

yes mostly because of the multiple event emitting bug from grid

@marcgarreau marcgarreau merged commit 0a0108d into master Sep 10, 2019

4 checks passed

Semantic Pull Request ready to be squashed
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-mac Your tests passed on CircleCI!
Details
ci/circleci: build-win Your tests passed on CircleCI!
Details

@marcgarreau marcgarreau deleted the dontClearErrorOnClick branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.