Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling errors when loading chain.rlp #575

Closed
lightclient opened this issue Jun 19, 2022 · 1 comment
Closed

Handling errors when loading chain.rlp #575

lightclient opened this issue Jun 19, 2022 · 1 comment

Comments

@lightclient
Copy link
Member

Right now, if nethermind (maybe other) clients fail to load chain.rlp because the block is invalid, they continue to startup. This can cause the test suite to run and then fail for non-obvious reasons. I think either i) clients should fail if chain.rlp fails to load or ii) hive should verify that the client has correctly loaded chain.rlp.

@fjl
Copy link
Collaborator

fjl commented Jun 22, 2022

Continuing to run is the expected behavior in this case. In some simulators, we use chain.rlp and blocks/ for testing with invalid chains. Also, there is no good way for a client to tell hive why it failed to start. It is basically expected that clients will start for any combination of HIVE_ environment options and chain files.

@fjl fjl closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants