New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet tab losing attributes #1489

Closed
evertonfraga opened this Issue Dec 1, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@evertonfraga
Member

evertonfraga commented Dec 1, 2016

Wallet tab loses its transparent nav bar, tab name and other attributes after a while.

image

Debugged as: Tabs.find({_id: 'wallet'}).fetch()

Damaged wallet tab object:

{
    id : "wallet"
    badge : "22.46 ETH"
    menu : Object
    permissions : Object
    position : 1
    url : "https://wallet.ethereum.org"
}

After hit reload, a healthy wallet tab object:

{
    _id: "wallet"
    appBar : "transparent"
    badge : "22.46 ETH"
    icon : "https://wallet.ethereum.org/wallet-icon.png"
    menu : Object
    name : "Ethereum Wallet"
    nameFull : "Ethereum Wallet"
    permissions : Object
    position : 1
    url : "https://wallet.ethereum.org"
    webviewId : 21
}

System information

Version: `0.8.7`
OS & Version: osx
Node type: `geth`

@evertonfraga evertonfraga self-assigned this Dec 1, 2016

@evertonfraga evertonfraga added this to the 0.9 milestone Dec 1, 2016

@frozeman

This comment has been minimized.

Member

frozeman commented Dec 1, 2016

I guess the issue comes from the way the wallet tab is added. By overwriting the existing one. We definitely need to change that.

Simply add a $set: {...} to the initial wallet adding.

We can talk about that tomorrow

frozeman added a commit that referenced this issue Dec 5, 2016

@evertonfraga evertonfraga modified the milestones: 0.9, 0.9.0 Mar 22, 2017

@lock

This comment has been minimized.

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.