New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error/infinite import of wallet-file #714

Closed
luclu opened this Issue May 25, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@luclu
Member

luclu commented May 25, 2016

The import of non-presale-wallets will cause a stalling/infinite import dialog.
Affected wallets (web3-secret-storage version 1 to 3):

  • myethereumwallet.com
  • kryptokit #631
  • Mist wallets (create wallet, move out of keystore and import)

We could also change the menu-label from import Pre-sale Accounts to import Wallet.

@alexvandesande

This comment has been minimized.

Collaborator

alexvandesande commented Aug 26, 2016

@luclu what's the status on this?

@luclu

This comment has been minimized.

Member

luclu commented Aug 29, 2016

There is an outstanding design decision - I would like to get your input at.

As you know the import-wallet view will ask for a password after the drop event, but as
web3-secret-storage-files just need to be copied it is not needed. Which gives me three possibilites:

  1. let the user input the password regardless of the wallet type and use the code at ipc_import-etc to decide on the procedure
  2. get some js to figure out the wallet type before proceeding to the password screen
  3. use user input elements to let the user decide on the wallet type
  4. create a second menuitem for web3-files

I would clearly prefer 2. but can't figure out a way to include fs to read and evaluate the json file for its type within meteor's onboarding js code (clientside).
Which leaves me with new ipc-command and evaluation before the user might be prompt for a password.

@hiddentao

This comment has been minimized.

Contributor

hiddentao commented Sep 12, 2016

(2) is the most elegant solution, but (3) is a decent fallback.

@evertonfraga evertonfraga modified the milestones: 0.8.3, 0.8.4 Sep 22, 2016

@luclu

This comment has been minimized.

Member

luclu commented Sep 24, 2016

Finally implemented basic functionality of (2) on the airplane today. ;)
Import of web3 as well as presale files is now possible, while the former will directly show the importing animation as a dummy for 750ms.

@evertonfraga evertonfraga modified the milestones: 0.8.4, 0.8.5 Sep 27, 2016

@evertonfraga evertonfraga removed this from the 0.8.5 milestone Oct 7, 2016

@evertonfraga evertonfraga modified the milestones: 0.9, 0.8.5 Oct 7, 2016

@luclu luclu referenced this issue Jan 17, 2017

Merged

Improve importer #1598

5 of 5 tasks complete

@luclu luclu closed this in #1598 Jan 25, 2017

@luclu luclu removed their assignment Mar 19, 2017

@evertonfraga evertonfraga modified the milestones: 0.9, 0.9.0 Mar 22, 2017

@lock

This comment has been minimized.

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.