Skip to content
This repository has been archived by the owner. It is now read-only.

error/infinite import of wallet-file #714

Closed
luclu opened this issue May 25, 2016 · 5 comments
Closed

error/infinite import of wallet-file #714

luclu opened this issue May 25, 2016 · 5 comments
Milestone

Comments

@luclu
Copy link
Contributor

@luclu luclu commented May 25, 2016

The import of non-presale-wallets will cause a stalling/infinite import dialog.
Affected wallets (web3-secret-storage version 1 to 3):

  • myethereumwallet.com
  • kryptokit #631
  • Mist wallets (create wallet, move out of keystore and import)

We could also change the menu-label from import Pre-sale Accounts to import Wallet.

@luclu luclu added this to the 0.8 milestone Jun 16, 2016
@luclu luclu removed this from the 0.8 milestone Jul 11, 2016
@luclu luclu added this to the 0.8.2 milestone Jul 11, 2016
@luclu luclu added this to the 0.8.2 milestone Jul 11, 2016
@luclu luclu removed this from the 0.8 milestone Jul 11, 2016
@luclu luclu mentioned this issue Jul 21, 2016
5 tasks
@luclu luclu self-assigned this Jul 26, 2016
@alexvandesande alexvandesande added this to the 0.8.3 milestone Aug 26, 2016
@alexvandesande alexvandesande removed this from the 0.8.2 milestone Aug 26, 2016
@alexvandesande
Copy link
Collaborator

@alexvandesande alexvandesande commented Aug 26, 2016

@luclu what's the status on this?

Loading

@luclu
Copy link
Contributor Author

@luclu luclu commented Aug 29, 2016

There is an outstanding design decision - I would like to get your input at.

As you know the import-wallet view will ask for a password after the drop event, but as
web3-secret-storage-files just need to be copied it is not needed. Which gives me three possibilites:

  1. let the user input the password regardless of the wallet type and use the code at ipc_import-etc to decide on the procedure
  2. get some js to figure out the wallet type before proceeding to the password screen
  3. use user input elements to let the user decide on the wallet type
  4. create a second menuitem for web3-files

I would clearly prefer 2. but can't figure out a way to include fs to read and evaluate the json file for its type within meteor's onboarding js code (clientside).
Which leaves me with new ipc-command and evaluation before the user might be prompt for a password.

Loading

@hiddentao
Copy link
Contributor

@hiddentao hiddentao commented Sep 12, 2016

(2) is the most elegant solution, but (3) is a decent fallback.

Loading

@evertonfraga evertonfraga removed this from the 0.8.3 milestone Sep 22, 2016
@evertonfraga evertonfraga added this to the 0.8.4 milestone Sep 22, 2016
@evertonfraga evertonfraga added this to the 0.8.4 milestone Sep 22, 2016
@evertonfraga evertonfraga removed this from the 0.8.3 milestone Sep 22, 2016
@luclu
Copy link
Contributor Author

@luclu luclu commented Sep 24, 2016

Finally implemented basic functionality of (2) on the airplane today. ;)
Import of web3 as well as presale files is now possible, while the former will directly show the importing animation as a dummy for 750ms.

Loading

@evertonfraga evertonfraga removed this from the 0.8.4 milestone Sep 27, 2016
@evertonfraga evertonfraga added this to the 0.8.5 milestone Sep 27, 2016
@evertonfraga evertonfraga added this to the 0.8.5 milestone Sep 27, 2016
@evertonfraga evertonfraga removed this from the 0.8.4 milestone Sep 27, 2016
@evertonfraga evertonfraga removed this from the 0.8.5 milestone Oct 7, 2016
@evertonfraga evertonfraga added this to the 0.9 milestone Oct 7, 2016
@evertonfraga evertonfraga added this to the 0.9 milestone Oct 7, 2016
@evertonfraga evertonfraga removed this from the 0.8.5 milestone Oct 7, 2016
@luclu luclu mentioned this issue Jan 17, 2017
5 tasks
@luclu luclu closed this in #1598 Jan 25, 2017
@luclu luclu removed their assignment Mar 19, 2017
@evertonfraga evertonfraga removed this from the 0.9 milestone Mar 22, 2017
@evertonfraga evertonfraga added this to the 0.9.0 milestone Mar 22, 2017
@evertonfraga evertonfraga added this to the 0.9.0 milestone Mar 22, 2017
@evertonfraga evertonfraga removed this from the 0.9 milestone Mar 22, 2017
@lock
Copy link

@lock lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

Loading

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants