New confirmation pane #1141

Merged
merged 24 commits into from Sep 14, 2016

Projects

None yet

5 participants

@alexvandesande
Collaborator

No description provided.

@alexvandesande
Collaborator

Ready to be merged

@luclu luclu commented on the diff Sep 8, 2016
.editorconfig
@@ -0,0 +1,9 @@
+root = true
@luclu
luclu Sep 8, 2016 edited Member

The editor config can be excluded locally only by using .git/info/exclude instead of .gitignore (same syntax).

@luclu
Member
luclu commented Sep 8, 2016 edited

@alexvandesande here is some cropped text-field I ran into:

edit: well, my OSX's scrolling did break, had to reboot. ;)
Perhaps the fade area could be enlarged and also set apart a bit further from the password input-field to make the visual distinction and scroll-ability more obvious.

bildschirmfoto 2016-09-08 um 22 44 10

@luclu
Member
luclu commented Sep 9, 2016 edited

There seems to be some issue with the SSL access (to 4bytes?) when trying to decode the data (on main-net and test-net):

bildschirmfoto 2016-09-08 um 23 34 59

Also, at some point in time using this branch I could not input any text in any text-field anymore (only deleting) until I restarted Ethereum-Wallet. I will try to observe and reproduce this.

@alexvandesande alexvandesande merged commit 581cd8e into develop Sep 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evertonfraga evertonfraga deleted the new-confirmation-pane branch Sep 14, 2016
@evertonfraga evertonfraga added this to the 0.8.3 milestone Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment