refactor OS-specific menu-items #1192

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@luclu
Member
luclu commented Sep 24, 2016 edited

closes #1168

Tested on win, linux, mac

@luclu luclu added the please review label Sep 24, 2016
interface/i18n/mist.en.i18n.json
@@ -71,7 +71,8 @@
"toFront": "Bring All to Front"
},
"help": {
- "label": "Help"
+ "label": "Help",
+ "reportBug": "Report a bug on Github"
@evertonfraga
evertonfraga Sep 26, 2016 Member

i created that reportbug thing. Maybe we should rephrase to "Report an issue on Github"?

@luclu
luclu Sep 26, 2016 Member

done! 👍

@evertonfraga evertonfraga added this to the 0.8.5 milestone Oct 7, 2016
+ }
+ );
+ }
+ if(process.platform === 'darwin') {
@evertonfraga
evertonfraga Oct 7, 2016 Member

@luclu is there a reason why is this enabled only on Mac?

@evertonfraga
evertonfraga Oct 7, 2016 edited Member

anyways, I removed this restriction and tested on Linux+Win. all worked

+ }
+ );
+ }
+ if(process.platform === 'darwin') {
@evertonfraga
evertonfraga Oct 7, 2016 edited Member

anyways, I removed this restriction and tested on Linux+Win. all worked

@evertonfraga
Member

merged on #1269.

@luclu luclu deleted the luclu:refactor_osx_menu_items branch Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment