[installer] adjust name of installation-folder #1213

Merged
merged 3 commits into from Sep 30, 2016

Projects

None yet

2 participants

@luclu
Member
luclu commented Sep 27, 2016 edited

fixes #1178

There is some minor problem with the package name..
electron-builder’s name variable will be used for linux and win as well:

  • win will use it as folder name under %localappdata% but will cut off anything starting with an {dash, space, point} as NuGet will internally convert - for example - spaces to %20 but won't allow % for package ids
  • linux will use it as the package name in all lowercase

...best would be IMHO:

  • win: Ethereum-Wallet
  • linux: ethereum-wallet

...possible would be:

  • win: EthereumWallet
  • linux: ethereumwallet

edit 9/28: There might be a solution, follow the white rabbit......

@luclu luclu added the please review label Sep 27, 2016
@luclu luclu merged commit ca5004b into ethereum:develop Sep 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@luclu luclu deleted the luclu:win-fix-wipe-out branch Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment