Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm integration #1661

Closed
wants to merge 9 commits into from

Conversation

Projects
None yet
1 participant
@MaiaVictor
Copy link
Contributor

MaiaVictor commented Feb 13, 2017

Swarm protocol integration on the Mist browser

  • Recognize bzz:// on the URL bar

  • Recognize bzz:// on elements inside the WebView

  • bzz addresses work as a different domains (for window.location, localStorage, etc.)

  • Load the Ethereum Wallet from Swarm

Swarm node manager

  • Download swarm binaries (resues clientBinaryManager.json's infrastructure)

  • Start/close the swarm process (managed by swarmNode.js)

This is a work in progress.

Some notes / TODOs:

  • Mandatory code duplication on the close function of swarmNode.js (it should have the same logic as ethereumNode.js's close). We could abstract that into a process spawner and avoid this duplication.

  • Still doesn't hide the Swarm account from the DApps

  • Doesn't check if Swarm is already running

  • Doesn't handle possible Swarm process crashes

  • Doesn't emit logs

MaiaVictor added some commits Feb 6, 2017

Implement Swarm node manager
This implements the Swarm node manager, which is responsible for starting and
closing the Swarm process properly. I'm trying to follow as closely as possible
the style I found in other files, although I'm a little concerned with some
patterns such as the use of global state and singletons. Those must be debated
later. There are still some things to implement and test in order for this to
be considered done.

@MaiaVictor MaiaVictor force-pushed the bzz_protocol branch 2 times, most recently from e99677d to f19df25 Feb 13, 2017

@MaiaVictor MaiaVictor force-pushed the bzz_protocol branch 2 times, most recently from 6365952 to de81753 Feb 13, 2017

@MaiaVictor MaiaVictor force-pushed the bzz_protocol branch from de81753 to 3b1e317 Feb 16, 2017

@MaiaVictor MaiaVictor closed this Mar 4, 2017

@evertonfraga evertonfraga deleted the bzz_protocol branch Aug 15, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 30, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 30, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.