Skip to content
This repository has been archived by the owner. It is now read-only.

Adding rinkeby support #2723

Merged
merged 18 commits into from Jul 10, 2017
Merged

Adding rinkeby support #2723

merged 18 commits into from Jul 10, 2017

Conversation

@evertonfraga
Copy link
Member

@evertonfraga evertonfraga commented Jul 6, 2017

As a bonus, user can also choose a local private network.

@evertonfraga evertonfraga added this to the 0.9.0 milestone Jul 6, 2017
@evertonfraga evertonfraga self-assigned this Jul 7, 2017
@@ -46,7 +46,7 @@
</p>

{{#if TemplateVar.get "testnet"}}
<p>{{{i18n "mist.popupWindows.onboarding.mineItDescription"}}}</p>
<p>{{{i18n "mist.popupWindows.onboarding.FaucetDescription"}}}</p>
Copy link
Contributor

@frozeman frozeman Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have made that camelCase

Copy link
Member Author

@evertonfraga evertonfraga Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frozeman done.

@@ -81,7 +90,7 @@ Template['popupWindows_onboardingScreen'].helpers({
@method syncStatus
*/
'syncStatus': function () {
syncStatus() {
Copy link
Contributor

@frozeman frozeman Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats ES6 right here, if we would remove the ecmascript package, this would break.

else {
switch (network) {
// STARTS ROPSTEN
case 'test':
Copy link
Contributor

@frozeman frozeman Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we call this "test" and the other by its name? To be backwards compatible?

Copy link
Member Author

@evertonfraga evertonfraga Jul 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some reasons:

  • backwards compatibility, yes
  • Geth refers to the networks as --testnet and --rinkeby, so we're actually being consistent with their flags
  • forward compatibility: that'll work even if the testnet flag changes to a different chain, so we're not being specific to Ropsten in the internals, only when it's displayed.

@frozeman
Copy link
Contributor

@frozeman frozeman commented Jul 9, 2017

I didn't test it on my machine, but it looks good from the code changes.

@evertonfraga evertonfraga merged commit 0c64083 into develop Jul 10, 2017
1 of 3 checks passed
@evertonfraga evertonfraga deleted the add-rinkeby-support branch Jul 10, 2017
@lock
Copy link

@lock lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants