Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing log message #3127

Merged
merged 2 commits into from Oct 4, 2017

Conversation

@evertonfraga
Copy link
Member

evertonfraga commented Oct 4, 2017

What does it do?

Fixes an undefined variable in current scope. Probably a typo.

How to reproduce it?

  1. Configure your Mist to run on main net, and close it.
  2. Start a separated geth node in testnet geth --rinkeby
  3. Start mist

Expected result is to warn "Bind address already in use".
Actual result: uncaught exception.

This PR aims to fix this.

evertonfraga added 2 commits Oct 4, 2017
@frozeman frozeman merged commit 9e33254 into develop Oct 4, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frozeman frozeman deleted the fix-uncaught-exception branch Oct 4, 2017
iquidus added a commit to ubiq/fusion that referenced this pull request Oct 7, 2017
* Fixing log message

* Logging the whole object
@moleisking

This comment has been minimized.

Copy link

moleisking commented Mar 21, 2018

I still get a error on Ethereum-Wallet-installer-0-9-2.exe in Windows 10 when connecting to the test network
=============== Mar 21, 2018 (CET) ===============
12:58:22.991039 log@legend F·NumFile S·FileSize N·Entry C·BadEntry B·BadBlock Ke·KeyError D·DroppedEntry L·Level Q·SeqNum T·TimeElapsed
12:58:22.991039 version@stat F·[1 1] S·34MiB[32MiB 1MiB] Sc·[0.25 0.02]
12:58:22.991039 db@open opening
12:58:22.991039 journal@recovery F·1
12:58:22.996050 journal@recovery recovering @26
12:58:23.000059 version@stat F·[1 1] S·34MiB[32MiB 1MiB] Sc·[0.25 0.02]
12:58:23.048996 db@janitor F·4 G·0
12:58:23.048996 db@open done T·57.9565ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.