Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-generating SHA256 checksums #3291

Merged
merged 2 commits into from Nov 16, 2017

Conversation

@evertonfraga
Copy link
Member

evertonfraga commented Nov 15, 2017

What does it do?

It runs sha256 against Mist/EW artifacts and appends them to the release notes if there are any release drafts.

Any helpful background information?

We used to distribute binaries with MD5 checksums. SHA-256 checksums were generated manually until now.

Which code should the reviewer start with?

New dependencies? What are they used for?

No.

Relevant screenshots?

This is what we aim for. We can't ensure what order the builds will finish, so it still requires a little text manipulation at the end, as all builds will print out the table header as well.

image

@evertonfraga evertonfraga mentioned this pull request Nov 15, 2017
@evertonfraga evertonfraga self-assigned this Nov 15, 2017
@evertonfraga evertonfraga added this to the 0.9.3 milestone Nov 15, 2017
@evertonfraga evertonfraga requested review from frozeman and marcgarreau Nov 15, 2017
@evertonfraga evertonfraga merged commit ed1578a into develop Nov 16, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@evertonfraga evertonfraga deleted the checksums-in-sha256 branch Nov 16, 2017
@ethereum ethereum deleted a comment from Taledeyo Mar 29, 2018
@ethereum ethereum deleted a comment from ja1977ja Mar 29, 2018
@ethereum ethereum locked as resolved and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.