New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constantinople Progress Tracker #53

Open
Souptacular opened this Issue Jul 30, 2018 · 51 comments

Comments

Projects
None yet
@Souptacular
Member

Souptacular commented Jul 30, 2018

This issue is meant to track the progress of client implementation and tests of the EIPs for the upcoming Constantinople hard fork.

Client Implementations

Client EIP 145: Bitwise shifting instructions in EVM EIP 1014: Skinny CREATE2 EIP 1052: EXTCODEHASH Opcode EIP 1283: Net gas metering for SSTORE without dirty maps (replaces 1087) EIP 1234: Constantinople Difficulty Bomb Delay and Block Reward Adjustment Meta Release Issue/PR
geth Yes Yes Yes Yes Yes No
Parity Ethereum Yes Yes Yes Yes Yes Yes
aleth Yes Yes Yes Yes Yes Yes
ethereumJ (Harmony) Yes Yes Yes Yes Yes Yes
Trinity Yes Yes Yes ✖️ No Yes Yes
ethereumJS Yes ⌛️ WIP ⌛️ WIP Yes ⌛️ WIP Yes
exthereum Idk Idk Idk Idk Idk No
Mana Yes Yes Yes Yes Yes Yes
Nethermind Yes Yes Yes Yes Yes Yes
Pantheon Yes Yes Yes Yes Yes No

Test Cases Spreadsheet

@carver

This comment has been minimized.

Show comment
Hide comment
@carver

carver commented Jul 30, 2018

Trinity Constantinople Milestone: https://github.com/ethereum/py-evm/milestone/2

@5chdn

This comment has been minimized.

Show comment
Hide comment
@5chdn

5chdn Jul 31, 2018

Parity Ethereum:

Did we decide to drop EIP-210? paritytech/parity-ethereum#5505

5chdn commented Jul 31, 2018

Parity Ethereum:

Did we decide to drop EIP-210? paritytech/parity-ethereum#5505

@jbaylina

This comment has been minimized.

Show comment
Hide comment
@jbaylina

jbaylina Jul 31, 2018

Is EIP-1108 and EIP-1109 going to be included in Constantinople ?

jbaylina commented Jul 31, 2018

Is EIP-1108 and EIP-1109 going to be included in Constantinople ?

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Jul 31, 2018

Member

Progress tracker for ethereumjs: ethereumjs/ethereumjs-vm#322

Member

axic commented Jul 31, 2018

Progress tracker for ethereumjs: ethereumjs/ethereumjs-vm#322

@ayrat555

This comment has been minimized.

Show comment
Hide comment
@ayrat555

ayrat555 commented Aug 1, 2018

Mana progress: poanetwork/mana#307

@pipermerriam

This comment has been minimized.

Show comment
Hide comment
@pipermerriam

pipermerriam Aug 1, 2018

Member

Trinity

Member

pipermerriam commented Aug 1, 2018

Trinity

@pipermerriam

This comment has been minimized.

Show comment
Hide comment
@pipermerriam

pipermerriam Aug 1, 2018

Member

Trinity: Here is the issue link for EIP1052

ethereum/py-evm#719

Member

pipermerriam commented Aug 1, 2018

Trinity: Here is the issue link for EIP1052

ethereum/py-evm#719

@mkalinin

This comment has been minimized.

Show comment
Hide comment
@mkalinin

mkalinin commented Aug 7, 2018

@cburgdorf

This comment has been minimized.

Show comment
Hide comment
@cburgdorf

cburgdorf Aug 7, 2018

@Souptacular you can check EIP 145 for Trinity. It's implemented in ethereum/py-evm#1134 and ethereum/py-evm#1112 which are both merged in latest master

cburgdorf commented Aug 7, 2018

@Souptacular you can check EIP 145 for Trinity. It's implemented in ethereum/py-evm#1134 and ethereum/py-evm#1112 which are both merged in latest master

@cburgdorf

This comment has been minimized.

Show comment
Hide comment
@cburgdorf

cburgdorf Aug 8, 2018

@Souptacular and EIP1052 landed in Trinity as well ethereum/py-evm#1147

cburgdorf commented Aug 8, 2018

@Souptacular and EIP1052 landed in Trinity as well ethereum/py-evm#1147

@Souptacular

This comment has been minimized.

Show comment
Hide comment
@Souptacular

Souptacular Aug 8, 2018

Member

Updated!

Member

Souptacular commented Aug 8, 2018

Updated!

@holgerd77

This comment has been minimized.

Show comment
Hide comment
@holgerd77

holgerd77 Aug 9, 2018

Can we eventually add progress on the test cases written in https://github.com/ethereum/tests to the progress tracker, maybe with the number of implemented/merged test cases on the column for an EIP? @winsvega?

Have absolutely no overview on the current state there.

In this context I just rediscovered this test cases collection spreadsheet for Metropolis, is this still updated/cared for or is there an alternative collection like this existing?

holgerd77 commented Aug 9, 2018

Can we eventually add progress on the test cases written in https://github.com/ethereum/tests to the progress tracker, maybe with the number of implemented/merged test cases on the column for an EIP? @winsvega?

Have absolutely no overview on the current state there.

In this context I just rediscovered this test cases collection spreadsheet for Metropolis, is this still updated/cared for or is there an alternative collection like this existing?

@winsvega

This comment has been minimized.

Show comment
Hide comment
@winsvega

winsvega Aug 9, 2018

yes. that google list is tracking new tests since before Metropolis. It is being updated.

winsvega commented Aug 9, 2018

yes. that google list is tracking new tests since before Metropolis. It is being updated.

@holgerd77

This comment has been minimized.

Show comment
Hide comment
@holgerd77

holgerd77 Aug 9, 2018

@winsvega Ah great, would be really good if you guys can keep the doc as up-to-date as possible and also make it clear which tests are implemented and where to find the implementation (like being done in the RETURN CODES sheet e.g.). This really helps us a lot on the implementation side!

holgerd77 commented Aug 9, 2018

@winsvega Ah great, would be really good if you guys can keep the doc as up-to-date as possible and also make it clear which tests are implemented and where to find the implementation (like being done in the RETURN CODES sheet e.g.). This really helps us a lot on the implementation side!

@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Aug 10, 2018

Contributor

cpp-ethereum / EXTCODEHASH implemented.

Contributor

chfast commented Aug 10, 2018

cpp-ethereum / EXTCODEHASH implemented.

@cburgdorf

This comment has been minimized.

Show comment
Hide comment
@cburgdorf

cburgdorf Aug 17, 2018

We implemented CREATE2 in Trinity. I will add that in contrast to the other new opcodes though, this one hasn't received much testing yet

ethereum/py-evm#1186

cburgdorf commented Aug 17, 2018

We implemented CREATE2 in Trinity. I will add that in contrast to the other new opcodes though, this one hasn't received much testing yet

ethereum/py-evm#1186

@zilm13

This comment has been minimized.

Show comment
Hide comment
@zilm13

zilm13 Aug 24, 2018

EthereumJ/Harmony:
EIP 145: Bitwise shifting instructions in EVM implemented
EIP 1052: EXTCODEHASH Opcode implemented
everything else in progress

zilm13 commented Aug 24, 2018

EthereumJ/Harmony:
EIP 145: Bitwise shifting instructions in EVM implemented
EIP 1052: EXTCODEHASH Opcode implemented
everything else in progress

@chfast

This comment has been minimized.

Show comment
Hide comment
@chfast

chfast Aug 31, 2018

Contributor

Aleth / EIP 1283 done: ethereum/aleth#5231

Contributor

chfast commented Aug 31, 2018

Aleth / EIP 1283 done: ethereum/aleth#5231

@5chdn

This comment has been minimized.

Show comment
Hide comment
@5chdn

5chdn Aug 31, 2018

Parity Ethereum / EIP-1234 in progress paritytech/parity-ethereum#9187

5chdn commented Aug 31, 2018

Parity Ethereum / EIP-1234 in progress paritytech/parity-ethereum#9187

@lrettig

This comment has been minimized.

Show comment
Hide comment
@lrettig

lrettig Sep 6, 2018

Collaborator

Added EIP-1234 to the tracker

Collaborator

lrettig commented Sep 6, 2018

Added EIP-1234 to the tracker

@gumb0

This comment has been minimized.

Show comment
Hide comment
@gumb0

gumb0 Sep 6, 2018

Member

Aleth / EIP-1234 done ethereum/aleth#5247

Member

gumb0 commented Sep 6, 2018

Aleth / EIP-1234 done ethereum/aleth#5247

@flygoing

This comment has been minimized.

Show comment
Hide comment
@flygoing

flygoing Sep 7, 2018

Can the links to 145/1014 be updated to point to their respective eips.ethereum.org page? 1014 points to the pull request, which makes it difficult for people unfamiliar with git to read it.

flygoing commented Sep 7, 2018

Can the links to 145/1014 be updated to point to their respective eips.ethereum.org page? 1014 points to the pull request, which makes it difficult for people unfamiliar with git to read it.

@5chdn

This comment has been minimized.

Show comment
Hide comment
@5chdn

5chdn Sep 8, 2018

Parity Ethereum merged EIP-1283 paritytech/parity-ethereum#9319

Parity Ethereum PR for EIP-1234 is paritytech/parity-ethereum#9480 now (merged)

Parity Ethereum is feature-complete. paritytech/parity-ethereum#9505

5chdn commented Sep 8, 2018

Parity Ethereum merged EIP-1283 paritytech/parity-ethereum#9319

Parity Ethereum PR for EIP-1234 is paritytech/parity-ethereum#9480 now (merged)

Parity Ethereum is feature-complete. paritytech/parity-ethereum#9505

@ayrat555

This comment has been minimized.

Show comment
Hide comment
@ayrat555

ayrat555 Sep 11, 2018

Mana implemented EIP-145 poanetwork/mana#417

ayrat555 commented Sep 11, 2018

Mana implemented EIP-145 poanetwork/mana#417

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 13, 2018

@Souptacular I think the link is broken for geth - EIP 1283

It should be ethereum/go-ethereum#17383

ghost commented Sep 13, 2018

@Souptacular I think the link is broken for geth - EIP 1283

It should be ethereum/go-ethereum#17383

@mkalinin

This comment has been minimized.

Show comment
Hide comment
@mkalinin

mkalinin Sep 14, 2018

EthereumJ EIP-1283 PR merged, ethereum/ethereumj#1173

mkalinin commented Sep 14, 2018

EthereumJ EIP-1283 PR merged, ethereum/ethereumj#1173

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Sep 17, 2018

Member

Ice age delay merged on Geth ethereum/go-ethereum#17675

Member

karalabe commented Sep 17, 2018

Ice age delay merged on Geth ethereum/go-ethereum#17675

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak Sep 18, 2018

EIP 145: Bitwise shifting instructions in EVM is done and tested in Nethermind, planning to work on all the remaining ones this week

tkstanczak commented Sep 18, 2018

EIP 145: Bitwise shifting instructions in EVM is done and tested in Nethermind, planning to work on all the remaining ones this week

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak Sep 18, 2018

EIP-1052 is done and tested in Nethermind

tkstanczak commented Sep 18, 2018

EIP-1052 is done and tested in Nethermind

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak commented Sep 18, 2018

Nethermind meta here: NethermindEth/nethermind#93

@ayrat555

This comment has been minimized.

Show comment
Hide comment
@ayrat555

ayrat555 commented Sep 18, 2018

Mana / EIP-1014 done poanetwork/mana#426

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak Sep 18, 2018

Nethermind EIP-1014 done

tkstanczak commented Sep 18, 2018

Nethermind EIP-1014 done

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak Sep 18, 2018

Nethermind EIP-1234 done

tkstanczak commented Sep 18, 2018

Nethermind EIP-1234 done

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak Sep 18, 2018

Nethermind EIP-1283 done

tkstanczak commented Sep 18, 2018

Nethermind EIP-1283 done

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak Sep 18, 2018

Nethermind all done, I will run available blockchain tests from ethereum/tests tomorrow to see if everything is fine.

tkstanczak commented Sep 18, 2018

Nethermind all done, I will run available blockchain tests from ethereum/tests tomorrow to see if everything is fine.

@tkstanczak

This comment has been minimized.

Show comment
Hide comment
@tkstanczak

tkstanczak Sep 19, 2018

Do we expect an ethereum/test branch for Constantinople? Noticed that develop branch has incorrect mix hashes, block rewards and stExtCodeHash tests missing. Does anyone have an info on the golden source of tests for Constantinople?

tkstanczak commented Sep 19, 2018

Do we expect an ethereum/test branch for Constantinople? Noticed that develop branch has incorrect mix hashes, block rewards and stExtCodeHash tests missing. Does anyone have an info on the golden source of tests for Constantinople?

@winsvega

This comment has been minimized.

Show comment
Hide comment
@winsvega

winsvega Sep 19, 2018

incorrect mixhashes are due to this change:
ethereum/tests#480

stExtCodeHash are not ready.
The Constantinople tests are marked by Constantinople section in tests itself. no need to create separate branch.

winsvega commented Sep 19, 2018

incorrect mixhashes are due to this change:
ethereum/tests#480

stExtCodeHash are not ready.
The Constantinople tests are marked by Constantinople section in tests itself. no need to create separate branch.

@zilm13

This comment has been minimized.

Show comment
Hide comment
@zilm13

zilm13 Sep 20, 2018

EthereumJ/Harmony
Implemented:
EIP-1014
EIP-1283
EIP-1234
So everything is done for us, but as Github tests are not final, we are following it and testing how do we pass all new tests. It's continuous task and some bugs in our EIP implementations could appear.

Our tracker: ethereum/ethereumj#1149

zilm13 commented Sep 20, 2018

EthereumJ/Harmony
Implemented:
EIP-1014
EIP-1283
EIP-1234
So everything is done for us, but as Github tests are not final, we are following it and testing how do we pass all new tests. It's continuous task and some bugs in our EIP implementations could appear.

Our tracker: ethereum/ethereumj#1149

@ayrat555

This comment has been minimized.

Show comment
Hide comment
@ayrat555

ayrat555 commented Sep 20, 2018

Mana / EIP-1283 done poanetwork/mana#433

@karalabe

This comment has been minimized.

Show comment
Hide comment
@karalabe

karalabe Sep 21, 2018

Member

Net sstore also merged on Geth ethereum/go-ethereum#17383 . We were waiting with this for a release, but postponed v1.8.16 for next Monday, so figured we can push it out now.

Member

karalabe commented Sep 21, 2018

Net sstore also merged on Geth ethereum/go-ethereum#17383 . We were waiting with this for a release, but postponed v1.8.16 for next Monday, so figured we can push it out now.

@cburgdorf

This comment has been minimized.

Show comment
Hide comment
@cburgdorf

cburgdorf Sep 22, 2018

@Souptacular EIP 1234 just landed in Trinity ethereum/py-evm#1303

cburgdorf commented Sep 22, 2018

@Souptacular EIP 1234 just landed in Trinity ethereum/py-evm#1303

@ayrat555

This comment has been minimized.

Show comment
Hide comment
@ayrat555

ayrat555 Sep 26, 2018

EIP 1234 is merged in Mana poanetwork/mana#447

ayrat555 commented Sep 26, 2018

EIP 1234 is merged in Mana poanetwork/mana#447

@mkalinin

This comment has been minimized.

Show comment
Hide comment
@mkalinin

mkalinin Oct 5, 2018

EthereumJ. CREATE2 gas price update merged ethereum/ethereumj#1204

mkalinin commented Oct 5, 2018

EthereumJ. CREATE2 gas price update merged ethereum/ethereumj#1204

@5chdn

This comment has been minimized.

Show comment
Hide comment
@5chdn

5chdn Oct 8, 2018

Parity Ethereum is ready to hardfork Ropsten w/ updated CREATE2 spec.

Preparing a compatible release now.

5chdn commented Oct 8, 2018

Parity Ethereum is ready to hardfork Ropsten w/ updated CREATE2 spec.

Preparing a compatible release now.

@ajsutton

This comment has been minimized.

Show comment
Hide comment
@ajsutton

ajsutton Oct 11, 2018

I'm happy to add that Pantheon has added support for all the Constantinople EIPs, including the updated CREATE2 spec.

ajsutton commented Oct 11, 2018

I'm happy to add that Pantheon has added support for all the Constantinople EIPs, including the updated CREATE2 spec.

@holgerd77

This comment has been minimized.

Show comment
Hide comment
@holgerd77

holgerd77 Oct 11, 2018

EthereumJS:
CREATE2 (EIP-1014):
Unknown -> WIP (ethereumjs/ethereumjs-vm#329)
SSTORE (EIP-1283):
Unknown -> now merged, ready (ethereumjs/ethereumjs-vm#367)
Difficulty Bomb (EIP-1234):
Unknown -> WIP (ethereumjs/ethereumjs-block#54)

holgerd77 commented Oct 11, 2018

EthereumJS:
CREATE2 (EIP-1014):
Unknown -> WIP (ethereumjs/ethereumjs-vm#329)
SSTORE (EIP-1283):
Unknown -> now merged, ready (ethereumjs/ethereumjs-vm#367)
Difficulty Bomb (EIP-1234):
Unknown -> WIP (ethereumjs/ethereumjs-block#54)

@cburgdorf

This comment has been minimized.

Show comment
Hide comment
@cburgdorf

cburgdorf Oct 22, 2018

@Souptacular trinity just landed support for EIP-1283 ethereum/py-evm#1410
Only thing left for us is to ensure we run all state tests for constantinople (which should land within the next days)

cburgdorf commented Oct 22, 2018

@Souptacular trinity just landed support for EIP-1283 ethereum/py-evm#1410
Only thing left for us is to ensure we run all state tests for constantinople (which should land within the next days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment