Add basic test vectors for the Portal wire protocol #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
commented
Nov 6, 2021
| #### Input Parameters | ||
| ``` | ||
| connection_id = [0x01, 0x02] | ||
| content_keys = [1, 0, 0, 0, 0, 0, 0, 0] # 8 bits bitlist, 0 bit set = byte 0x01 |
There was a problem hiding this comment.
Not sure if this is clear. How to best represent here a bitlist?
There was a problem hiding this comment.
I think this is fine with the bitlist annotation. In JS, I'm mapping this to an actual array of Booleans and evidently there is something wrong with my encoding since your inputs produce 08010206000000ff01 when I serialize it.
acolytec3
reviewed
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding some basic test vectors to resolve #101
These were generated with the Fluffy implementation (this branch: https://github.com/status-im/nimbus-eth1/tree/use-ssz-union) and the test cases can also be seen/run from this test: https://github.com/status-im/nimbus-eth1/blob/use-ssz-union/fluffy/tests/test_portal_wire_encoding.nim.
That branch should implement the latest Portal wire specification, but there might be mistakes obviously. If something looks odd or is unclear, let me know.