WIP: Storage, Bandwidth, and Processing requirements #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
reviewed
Dec 9, 2021
projected-resource-requirements.md
Outdated
|
|
||
| #### Base protocol message overhead | ||
|
|
||
| We expect most messages to use the regular MESSAGE type packet from discovery v5 which has 39 bytes of overhead. |
There was a problem hiding this comment.
I know I should ignore the PR for the time being, but my eye fell on this part :)
I think the 39 bytes should be 71 bytes. Forgot the source id of 32 bytes perhaps?
kdeme
reviewed
Dec 9, 2021
| We expect each TALKREQ message to contain: | ||
|
|
||
| - `request-id`: 4 bytes | ||
| - `protocol-id`: 2 bytes |
There was a problem hiding this comment.
This could be anywhere between 1 and 8 bytes. Depends on implementations how many are used.
kdeme
reviewed
Dec 9, 2021
projected-resource-requirements.md
Outdated
| - `protocol-id`: 2 bytes | ||
| - `payload`: variable | ||
|
|
||
| Combined with the base overhead from the message packet this gives us 55 bytes of overhead per packet. |
There was a problem hiding this comment.
Nitpick but there are also going to be a few bytes of overhead from the rlp encoding of the message.
pipermerriam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore me