Package up base db and atomic db test suites into re-usable classes #1813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1812
What was wrong?
The atomic and base DB test suites are useful outside of the py-evm library but they were not re-usable in the form they were written. Also most of the base database test suite was duplicated.
How was it fixed?
Packaged the test suites up into class-based tests and put them under
eth.tools.db
.I also expanded the test suite to cover the
batch
object for theAtomicDB
as well as and the base db suite to cover theCacheDB
.To-Do
Cute Animal Picture