Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to eth-utils >=1.7.0 #1846

Merged

Conversation

@pipermerriam
Copy link
Member

commented Sep 5, 2019

What was wrong?

Better API for ExtendedDebugLogger now available via eth-utils>=1.7.0

How was it fixed?

Updated dependency and removed the local implementations. This also includes removal of the setup of the DEBUG2 level in eth/__init__.py since it is no longer strictly necessary.

The DEBUG2 log level is now setup as part of the test runs via tests/conftest.py

To-Do

  • Clean up commit history

Cute Animal Picture

2d85501b342e5a182ed47dcd8a512e7a--cutest-animals-funny-animals

@pipermerriam pipermerriam force-pushed the pipermerriam:piper/update-eth-utils-1.7 branch from 0751170 to 667ece3 Sep 5, 2019

@pipermerriam pipermerriam force-pushed the pipermerriam:piper/update-eth-utils-1.7 branch from 667ece3 to 6f53293 Sep 5, 2019

@pipermerriam pipermerriam requested a review from carver Sep 5, 2019

@pipermerriam pipermerriam referenced this pull request Sep 5, 2019
2 of 2 tasks complete
@carver
carver approved these changes Sep 5, 2019

@pipermerriam pipermerriam merged commit 82a016c into ethereum:master Sep 5, 2019

20 checks passed

ci/circleci: py36-benchmark Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-database Your tests passed on CircleCI!
Details
ci/circleci: py36-docs Your tests passed on CircleCI!
Details
ci/circleci: py36-lint Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-byzantium Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-constantinople Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-frontier Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-homestead Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-petersburg Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-spurious_dragon Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-tangerine_whistle Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-transition Your tests passed on CircleCI!
Details
ci/circleci: py36-transactions Your tests passed on CircleCI!
Details
ci/circleci: py36-vm Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-database Your tests passed on CircleCI!
Details
ci/circleci: py37-lint Your tests passed on CircleCI!
Details
ci/circleci: py37-transactions Your tests passed on CircleCI!
Details
ci/circleci: py37-vm Your tests passed on CircleCI!
Details

@pipermerriam pipermerriam deleted the pipermerriam:piper/update-eth-utils-1.7 branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.