Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable Istanbul fork on Ropsten chain #1851

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@voith
Copy link
Contributor

commented Sep 18, 2019

What was wrong?

It has been decided that the istanbul fork will happen at block number 6485846.
Here's a screenshot of the message picked from AllCoreDevs gitter channel:

Screen Shot 2019-09-18 at 7 07 11 PM

How was it fixed?

Updated the RopstenChain to include the Istanbul fork.

Note for code owners: You can wait to merge till there is more consensus on the block number. But until now there haven't been any objections from anyone.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

added release notes
@voith voith force-pushed the voith:istanbul-ropsten branch from 93ba74c to 9ba08e0 Sep 18, 2019
@pipermerriam pipermerriam dismissed their stale review Sep 18, 2019

trigger happy

Copy link
Member

left a comment

Can you scan things like tests for places where the petersburg VM is the default?

latest_mainnet_at = petersburg_at

These will need to be updated as well though I suppose only when we update the mainnet block numbers....

@pipermerriam

This comment has been minimized.

Copy link
Member

commented Sep 18, 2019

Oh, also can you update the eth.tools.builder tools to have the appropriate instanbul tools?

@voith

This comment has been minimized.

Copy link
Contributor Author

commented Sep 18, 2019

@pipermerriam I will make the changes that you've requested. But I don't think that they should be part of this PR. I have decided to update upstream tests for Istanbul. I will figure out the changes needed along the way.

@pipermerriam pipermerriam merged commit 1254611 into ethereum:master Sep 18, 2019
20 checks passed
20 checks passed
ci/circleci: py36-benchmark Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-database Your tests passed on CircleCI!
Details
ci/circleci: py36-docs Your tests passed on CircleCI!
Details
ci/circleci: py36-lint Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-byzantium Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-constantinople Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-frontier Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-homestead Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-petersburg Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-spurious_dragon Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-tangerine_whistle Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-transition Your tests passed on CircleCI!
Details
ci/circleci: py36-transactions Your tests passed on CircleCI!
Details
ci/circleci: py36-vm Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-database Your tests passed on CircleCI!
Details
ci/circleci: py37-lint Your tests passed on CircleCI!
Details
ci/circleci: py37-transactions Your tests passed on CircleCI!
Details
ci/circleci: py37-vm Your tests passed on CircleCI!
Details
@voith voith deleted the voith:istanbul-ropsten branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.