Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Drop check_seal support from validate_header #1909
What was wrong?
How was it fixed?
@carver suggested to take the seal check out of this method. I initially was a bit skeptical about that as it comes with the risk of simply forgetting about the check. But in practice, there are few places where we explicitly need to call this and higher level code usually deals with APIs such as
So yeah, this PR drops
Cute Animal Picture
carver left a comment
Yup, actually I am less ambivalent about this than I thought. I like it quite a bit.
The boolean flag that triggers other checks underneath had a bit of a code smell to me that I'm happy to see cleaned up.
Yeah, it comes with the risk of forgetting to