Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import_block return refactor #1910

Merged
merged 3 commits into from Jan 14, 2020
Merged

import_block return refactor #1910

merged 3 commits into from Jan 14, 2020

Conversation

@g-r-a-n-t
Copy link
Contributor

g-r-a-n-t commented Jan 13, 2020

What was wrong?

See #1881

How was it fixed?

Created the named tuple and used it.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

renamed non_canonical_blocks

spacing

fixed
@g-r-a-n-t g-r-a-n-t force-pushed the g-r-a-n-t:master branch from b027e4a to 08833f1 Jan 13, 2020
Copy link
Contributor

cburgdorf left a comment

Thanks for jumping on this. Do you mind creating a file 1910.feature.rst at https://github.com/ethereum/py-evm/tree/master/newsfragments

Content would be something like:

Change return type for import_block from Tuple[BlockAPI, Tuple[BlockAPI, ...], Tuple[BlockAPI, ...]] to BlockImportResult (NamedTuple).

This is to ensure that it will go into the upcoming release notes.

@g-r-a-n-t

This comment has been minimized.

Copy link
Contributor Author

g-r-a-n-t commented Jan 13, 2020

Should be good now.

@g-r-a-n-t g-r-a-n-t closed this Jan 14, 2020
@g-r-a-n-t g-r-a-n-t reopened this Jan 14, 2020
@cburgdorf cburgdorf merged commit d44d846 into ethereum:master Jan 14, 2020
21 checks passed
21 checks passed
ci/circleci: py36-benchmark Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-database Your tests passed on CircleCI!
Details
ci/circleci: py36-docs Your tests passed on CircleCI!
Details
ci/circleci: py36-lint Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-byzantium Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-constantinople Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-frontier Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-homestead Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-istanbul Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-petersburg Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-spurious_dragon Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-tangerine_whistle Your tests passed on CircleCI!
Details
ci/circleci: py36-native-blockchain-transition Your tests passed on CircleCI!
Details
ci/circleci: py36-transactions Your tests passed on CircleCI!
Details
ci/circleci: py36-vm Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-database Your tests passed on CircleCI!
Details
ci/circleci: py37-lint Your tests passed on CircleCI!
Details
ci/circleci: py37-transactions Your tests passed on CircleCI!
Details
ci/circleci: py37-vm Your tests passed on CircleCI!
Details
@cburgdorf

This comment has been minimized.

Copy link
Contributor

cburgdorf commented Jan 14, 2020

Thank you for your contribution 🙏 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.