From 8d8d770466fd08e2179b525cf156cd114c3e0f27 Mon Sep 17 00:00:00 2001 From: serapath Date: Tue, 14 Aug 2018 15:35:00 +0100 Subject: [PATCH 1/2] add console.warn to terminal --- package.json | 4 ++-- src/app/panels/terminal.js | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index ddad3154487..1289ebc1adf 100644 --- a/package.json +++ b/package.json @@ -147,7 +147,7 @@ "linkremixcore": "cd node_modules && rm -rf remix-core && ln -s ../remix/remix-core remix-core && cd ..", "linkremixlib": "cd node_modules && rm -rf remix-lib && ln -s ../remix/remix-lib remix-lib && cd ..", "linkremixsolidity": "cd node_modules && rm -rf remix-solidity && ln -s ../remix/remix-solidity remix-solidity && cd ..", - "build": "browserify src/index.js -o build/app.js", + "build": "browserify src/index.js -o build/app.js --exclude solc", "build_debugger": "browserify src/app/debugger/remix-debugger/index.js -o src/app/debugger/remix-debugger/build/app.js", "browsertest": "sleep 5 && npm run nightwatch_local", "csslint": "csslint --ignore=order-alphabetical --errors='errors,duplicate-properties,empty-rules' --exclude-list='assets/css/font-awesome.min.css' assets/css/", @@ -174,6 +174,6 @@ "start": "npm-run-all -lpr serve watch onchange remixd", "test": "npm run csslint; standard && node test/index.js", "test-browser": "npm-run-all -lpr selenium downloadsolc_root make-mock-compiler serve browsertest", - "watch": "watchify src/index.js -dv -p browserify-reload -o build/app.js" + "watch": "watchify src/index.js -dv -p browserify-reload -o build/app.js --exclude solc" } } diff --git a/src/app/panels/terminal.js b/src/app/panels/terminal.js index c837da66cc8..5731f455414 100644 --- a/src/app/panels/terminal.js +++ b/src/app/panels/terminal.js @@ -73,6 +73,7 @@ class Terminal { self.registerCommand('html', self._blocksRenderer('html'), { activate: true }) self.registerCommand('log', self._blocksRenderer('log'), { activate: true }) self.registerCommand('info', self._blocksRenderer('info'), { activate: true }) + self.registerCommand('warn', self._blocksRenderer('warn'), { activate: true }) self.registerCommand('error', self._blocksRenderer('error'), { activate: true }) self.registerCommand('script', function execute (args, scopedCommands, append) { var script = String(args[0]) @@ -86,6 +87,7 @@ class Terminal { self.registerFilter('log', basicFilter) self.registerFilter('info', basicFilter) + self.registerFilter('warn', basicFilter) self.registerFilter('error', basicFilter) self.registerFilter('script', basicFilter) @@ -481,7 +483,7 @@ class Terminal { if (args.length) append(args[0]) } } - mode = { log: styles.terminal.text_RegularLog, info: styles.terminal.text_InfoLog, error: styles.terminal.text_ErrorLog }[mode] // defaults + mode = { log: styles.terminal.text_RegularLog, info: styles.terminal.text_InfoLog, warn: 'yellow', error: styles.terminal.text_ErrorLog }[mode] // defaults if (mode) { return function logger (args, scopedCommands, append) { var types = args.map(type) @@ -581,6 +583,7 @@ function domTerminalFeatures (self, scopedCommands) { console: { log: function () { scopedCommands.log.apply(scopedCommands, arguments) }, info: function () { scopedCommands.info.apply(scopedCommands, arguments) }, + warn: function () { scopedCommands.warn.apply(scopedCommands, arguments) }, error: function () { scopedCommands.error.apply(scopedCommands, arguments) } }, setTimeout: (fn, time) => { From 83867fde1a4ef19b1d1913476ff883b0a54318fe Mon Sep 17 00:00:00 2001 From: serapath Date: Tue, 21 Aug 2018 15:09:17 +0100 Subject: [PATCH 2/2] add warning color to stylesheet --- src/app/panels/terminal.js | 2 +- src/app/ui/styles-guide/style-guide.js | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/app/panels/terminal.js b/src/app/panels/terminal.js index 5731f455414..1560f2c4466 100644 --- a/src/app/panels/terminal.js +++ b/src/app/panels/terminal.js @@ -483,7 +483,7 @@ class Terminal { if (args.length) append(args[0]) } } - mode = { log: styles.terminal.text_RegularLog, info: styles.terminal.text_InfoLog, warn: 'yellow', error: styles.terminal.text_ErrorLog }[mode] // defaults + mode = { log: styles.terminal.text_RegularLog, info: styles.terminal.text_InfoLog, warn: styles.terminal.text_WarnLog, error: styles.terminal.text_ErrorLog }[mode] // defaults if (mode) { return function logger (args, scopedCommands, append) { var types = args.map(type) diff --git a/src/app/ui/styles-guide/style-guide.js b/src/app/ui/styles-guide/style-guide.js index 0833b364b01..a4d52fbebae 100644 --- a/src/app/ui/styles-guide/style-guide.js +++ b/src/app/ui/styles-guide/style-guide.js @@ -455,6 +455,7 @@ function styleGuide () { text_RegularLog: appProperties.mainText_Color, text_InfoLog: appProperties.supportText_Color, text_ErrorLog: appProperties.errorText_Color, + text_WarnLog: appProperties.warningText_Color, text_Title_TransactionLog: appProperties.infoText_Color, text_Regular_TransactionLog: appProperties.supportText_Color, text_Button: appProperties.oppositeText_Color,