Hide Highlights of plugin if not in focused #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Oct 28, 2020
yann300
reviewed
Oct 28, 2020
yann300
reviewed
Oct 28, 2020
| this.source = null | ||
| if (lineColumnPos) { | ||
| this.source = filePath | ||
| if (!this.source) this.source = this._deps.fileManager.currentFile() |
Contributor
There was a problem hiding this comment.
Why do you need to do that? i'd say if filePath is not defined the function can't anyway process and should return an error or just return.
yann300
reviewed
Oct 28, 2020
Contributor
|
That should probably need a little e2e test. |
yann300
reviewed
Oct 28, 2020
ioedeveloper
requested changes
Nov 2, 2020
ioedeveloper
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.