Skip to content

Conversation

@bunsenstraat
Copy link
Collaborator

@bunsenstraat bunsenstraat commented Jan 11, 2021

the focus method is exposed through the plugin, so I added the super method so we can actually use it. Before that, on the side panel it was only used to emit an event that triggered highlighting being cleared or something. Let's discuss.

@yann300
Copy link
Contributor

yann300 commented Jan 13, 2021

what action does the super.focus?

@bunsenstraat
Copy link
Collaborator Author

what action does the super.focus?

  showContent (name) {
    if (!this.contents[name]) throw new Error(`Plugin ${name} is not yet activated`)
    // hiding the current view and display the `moduleName`
    if (this.active) {
      this.contents[this.active].style.display = 'none'
    }
    this.contents[name].style.display = 'flex'
    this.active = name
  }

  focus (name) {
    this.showContent(name)
  }

on panel

trailing spaces
@yann300 yann300 enabled auto-merge January 20, 2021 10:52
@yann300 yann300 merged commit c702880 into master Jan 20, 2021
@yann300 yann300 deleted the bunsenstraat-patch-1 branch January 20, 2021 10:54
yann300 pushed a commit that referenced this pull request Jun 1, 2022
pin ipfs version, add note on chain running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants