New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial support for mapping types #498

Merged
merged 11 commits into from May 24, 2017

Conversation

Projects
None yet
3 participants
@cdetrio
Member

cdetrio commented May 2, 2017

Work in progress, don't merge.

remix mappings - screen shot 2017-05-02 at 12 17 01 pm

@chriseth chriseth added the in progress label May 2, 2017

@yann300

This comment has been minimized.

Show comment
Hide comment
@yann300

yann300 May 4, 2017

Collaborator

cool!!

Collaborator

yann300 commented May 4, 2017

cool!!

@cdetrio

This comment has been minimized.

Show comment
Hide comment
@cdetrio

cdetrio May 4, 2017

Member

@yann300 btw feel free to review and intervene early. Particularly in src/ui/SolidityState.js and the call to storageViewer.storageRange, that will probably get refactored to support getting preimages using debug_preimage (see ethereum/go-ethereum#3543 and ethereum/go-ethereum#3407).

Member

cdetrio commented May 4, 2017

@yann300 btw feel free to review and intervene early. Particularly in src/ui/SolidityState.js and the call to storageViewer.storageRange, that will probably get refactored to support getting preimages using debug_preimage (see ethereum/go-ethereum#3543 and ethereum/go-ethereum#3407).

@yann300 yann300 changed the title from [WIP] initial support for mapping types to initial support for mapping types May 18, 2017

Show outdated Hide outdated src/solidity/decodeInfo.js Outdated
@yann300

This comment has been minimized.

Show comment
Hide comment
@yann300

yann300 May 18, 2017

Collaborator

yeah the length here is not really relevant. but removing this breaks tests

Collaborator

yann300 commented May 18, 2017

yeah the length here is not really relevant. but removing this breaks tests

* @return {Array} containing all members of the current struct type
*/
function getStructMembers (type, stateDefinitions, contractName, location) {

This comment has been minimized.

@chriseth

chriseth May 22, 2017

Collaborator

Please add a test for the following type: struct X { uint a; mapping(uint=>uint) b; uint c; }
If such a struct is used in memory, it should be identical to struct X { uint a; uint c; }.

@chriseth

chriseth May 22, 2017

Collaborator

Please add a test for the following type: struct X { uint a; mapping(uint=>uint) b; uint c; }
If such a struct is used in memory, it should be identical to struct X { uint a; uint c; }.

This comment has been minimized.

@yann300

yann300 May 22, 2017

Collaborator

issue #510

@yann300

yann300 May 22, 2017

Collaborator

issue #510

Show outdated Hide outdated src/solidity/types/Mapping.js Outdated
@@ -0,0 +1,58 @@
var global = require('../helpers/global')

This comment has been minimized.

@chriseth

chriseth May 22, 2017

Collaborator

Please document all functions here.

@chriseth

chriseth May 22, 2017

Collaborator

Please document all functions here.

Show outdated Hide outdated src/storage/storageViewer.js Outdated
Show outdated Hide outdated src/web3Provider/web3VmProvider.js Outdated
Show outdated Hide outdated src/web3Provider/web3VmProvider.js Outdated
*
* @param {Function} callback
*/
async mappingsLocation () {

This comment has been minimized.

@yann300

yann300 May 24, 2017

Collaborator

return a promise

@yann300

yann300 May 24, 2017

Collaborator

return a promise

@yann300 yann300 merged commit ef68c8a into ethereum:master May 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment