"this used in constructor" static analysis rule has false positives

[frangio]

One of the warnings emitted by the static analyzer is "this" used in constructor from #2605.

solidity/libsolidity/analysis/StaticAnalyzer.cpp

Lines 210 to 211 in fe61435

	if (type->contractDefinition() == *m_currentContract)
	m_errorReporter.warning(_memberAccess.location(), "\"this\" used in constructor.");

The warning was implemented by checking that the static type of the LHS of a member access is the same as the contract being defined. But this wrongly catches other scenarios too such as:

pragma solidity ^0.4.14;

contract Foo {
    bool public bar;
    
    function Foo(Foo other) public {
        require(other.bar());
    }
}

[nbauernfeind]

Using super also causes a false positive. See #3861.