Experimental mloadresolver #10681
Closed
Experimental mloadresolver #10681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkrshnn
force-pushed
the
experimental-mloadresolver
branch
from
542b096 to
e4c47aa
Compare
hrkrshnn
force-pushed
the
experimental-mloadresolver
branch
from
e4c47aa to
b698618
Compare
hrkrshnn
commented
Dec 22, 2020
| case 0 { data := 96 } | ||
| default { | ||
| let result := and(add(returndatasize(), 63), not(31)) | ||
| let memPtr := mload(64) |
Contributor
Author
There was a problem hiding this comment.
Example from #10645. This mload(64) can be resolved.
chriseth
reviewed
Dec 22, 2020
| case evmasm::Instruction::EXTCODESIZE: | ||
| case evmasm::Instruction::MSIZE: | ||
| case evmasm::Instruction::RETURNDATASIZE: | ||
| return newRestrictedVariable(bigint(1) << 32); |
hrkrshnn
commented
Jan 4, 2021
Comment on lines
+527
to
+537
| { | ||
| // Avoiding wrapping | ||
| m_solver->push(); | ||
| m_solver->addAssertion(arguments.at(0) + arguments.at(1) >= (bigint(1) << 256)); | ||
| CheckResult result = m_solver->check({}).first; | ||
| m_solver->pop(); | ||
| if (result == CheckResult::UNSATISFIABLE) | ||
| return arguments.at(0) + arguments.at(1); | ||
| else | ||
| return newRestrictedVariable(); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@ekpyron here is an example of relaxation.
Contributor
Author
|
Closing this to reduced PR count. The PR has enough information for future needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.