New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This in constructor #2605

Merged
merged 3 commits into from Jul 19, 2017

Conversation

Projects
None yet
2 participants
@roadriverrail
Contributor

roadriverrail commented Jul 19, 2017

Rebased and using the ErrorReporter.

This replaces pull request #1646

Fixes #583.

@roadriverrail

This comment has been minimized.

Show comment
Hide comment
@roadriverrail

roadriverrail Jul 19, 2017

Contributor

I believe that, in conversation with @chriseth back in June, we'd agreed to not pursue a complete call graph from the constructor to hunt down all indirect uses of this. If that's still the case, then I think the work here is done-- it's rebased, reporting warnings through ErrorReporter, and has a test case.

Fixes #583

Contributor

roadriverrail commented Jul 19, 2017

I believe that, in conversation with @chriseth back in June, we'd agreed to not pursue a complete call graph from the constructor to hunt down all indirect uses of this. If that's still the case, then I think the work here is done-- it's rebased, reporting warnings through ErrorReporter, and has a test case.

Fixes #583

@axic

axic approved these changes Jul 19, 2017

@axic axic merged commit 1274108 into ethereum:develop Jul 19, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment