New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.delegatecall() should always return a boolean of execution status #2679

Merged
merged 4 commits into from Aug 2, 2017

Conversation

Projects
None yet
2 participants
@axic
Member

axic commented Aug 1, 2017

Fixes #2678.

@axic axic added the in progress label Aug 1, 2017

@axic axic requested a review from chriseth Aug 1, 2017

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 1, 2017

Contributor

Please also add an entry in the bug list json.

Contributor

chriseth commented Aug 1, 2017

Please also add an entry in the bug list json.

Show outdated Hide outdated docs/bugs.json Outdated
Show outdated Hide outdated docs/bugs.json Outdated
Show outdated Hide outdated docs/bugs.json Outdated
Show outdated Hide outdated docs/bugs.json Outdated
@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 2, 2017

Member

@chriseth should be ready

Member

axic commented Aug 2, 2017

@chriseth should be ready

@chriseth chriseth merged commit bd9e910 into develop Aug 2, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chriseth chriseth removed the in progress label Aug 2, 2017

@axic axic deleted the delegatecall branch Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment