New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark overloaded functions as shadowing #2692

Merged
merged 3 commits into from Aug 4, 2017

Conversation

Projects
None yet
2 participants
@axic
Member

axic commented Aug 3, 2017

Fixes #2676.

@axic axic requested a review from chriseth Aug 3, 2017

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 4, 2017

Contributor

I will find a test case that fails on my comment and then fix it.

Contributor

chriseth commented Aug 4, 2017

I will find a test case that fails on my comment and then fix it.

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 4, 2017

Contributor

I'm changing the condition to "warn about shadowing if the parent scope (or one of its parent scopes) contains an identifier of the same name". I think this should catch all cases and does not introduce any false positives. I will check if this is true for the global scope.

Contributor

chriseth commented Aug 4, 2017

I'm changing the condition to "warn about shadowing if the parent scope (or one of its parent scopes) contains an identifier of the same name". I think this should catch all cases and does not introduce any false positives. I will check if this is true for the global scope.

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 4, 2017

Member

Do we need to add more tests to this then?

Member

axic commented Aug 4, 2017

Do we need to add more tests to this then?

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 4, 2017

Contributor

Yes, I think we should.

Contributor

chriseth commented Aug 4, 2017

Yes, I think we should.

@chriseth chriseth merged commit f3af014 into develop Aug 4, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@axic axic deleted the shadowing-overload branch Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment