New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when using unimplemented internal library functions. #2697

Merged
merged 2 commits into from Aug 8, 2017

Conversation

Projects
None yet
2 participants
@axic
Member

axic commented Aug 4, 2017

Fixes #1769.

@axic axic added the nextrelease label Aug 4, 2017

@axic axic requested a review from chriseth Aug 4, 2017

@axic axic added in progress and removed nextrelease labels Aug 4, 2017

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 4, 2017

Member

This also catches:

library L {
  function f() internal;
  fucntion g() { f(); }
}

but that is fine since libraries can inherit other libraries so no way to implement it.

Member

axic commented Aug 4, 2017

This also catches:

library L {
  function f() internal;
  fucntion g() { f(); }
}

but that is fine since libraries can inherit other libraries so no way to implement it.

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 4, 2017

Member

Will disable unimplemented internal library functions in FunctionDefinition, but also need to come up with a more comprehensive list of tests for that.

Member

axic commented Aug 4, 2017

Will disable unimplemented internal library functions in FunctionDefinition, but also need to come up with a more comprehensive list of tests for that.

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 8, 2017

Member

@chriseth this should be ready

Member

axic commented Aug 8, 2017

@chriseth this should be ready

{
char const* text = R"(
library L {
function f();

This comment has been minimized.

@axic

axic Aug 8, 2017

Member

I can see a point of keeping this, since at link time an address can be supplied which has it implemented. Also disallowing this would be a breaking change.

@axic

axic Aug 8, 2017

Member

I can see a point of keeping this, since at link time an address can be supplied which has it implemented. Also disallowing this would be a breaking change.

@chriseth chriseth merged commit 41e7243 into develop Aug 8, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@axic axic deleted the unimplemented-inlined-library branch Aug 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment