New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for payable when comparing function types #2724

Merged
merged 2 commits into from Aug 11, 2017

Conversation

Projects
None yet
3 participants
@axic
Member

axic commented Aug 9, 2017

No description provided.

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 10, 2017

Member

This oversight is not causing any issues yet, because it is checked in TypeChecker for use supplied functions.

Member

axic commented Aug 10, 2017

This oversight is not causing any issues yet, because it is checked in TypeChecker for use supplied functions.

@chriseth

Hm, there might have been a reason for that or it was just oversight. Please also add _payable to the type identifier. The idea is x !=y <=> x.identifier() != y.identifier()

@axic

This comment has been minimized.

Show comment
Hide comment
@axic
Member

axic commented Aug 10, 2017

@chriseth done

@chriseth chriseth merged commit c84de7f into develop Aug 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chriseth chriseth removed the in progress label Aug 11, 2017

@axic axic deleted the function-type-payable branch Aug 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment