New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce view and pure. #2848

Merged
merged 16 commits into from Sep 13, 2017

Conversation

Projects
None yet
2 participants
@chriseth
Contributor

chriseth commented Aug 29, 2017

Depends on #2857

  • analyze assembly
@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 29, 2017

Contributor

Removed msg.value from the things allowed for pure functions in line with the current documentation.

Contributor

chriseth commented Aug 29, 2017

Removed msg.value from the things allowed for pure functions in line with the current documentation.

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 29, 2017

Contributor
  • 10 test failures still to be solved
  • new tests to be written
  • assembly to be analyzed
Contributor

chriseth commented Aug 29, 2017

  • 10 test failures still to be solved
  • new tests to be written
  • assembly to be analyzed
@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 30, 2017

Contributor

Everything ready apart from analyzing assembly.

Contributor

chriseth commented Aug 30, 2017

Everything ready apart from analyzing assembly.

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Aug 31, 2017

Contributor

Only thing still missing: Tests for assembly.

Contributor

chriseth commented Aug 31, 2017

Only thing still missing: Tests for assembly.

@@ -188,3 +188,56 @@ bool SemanticInformation::invalidatesStorage(Instruction _instruction)
return false;
}
}
bool SemanticInformation::invalidInPureFunctions(Instruction _instruction)

This comment has been minimized.

@axic

axic Sep 1, 2017

Member

I'd call this "readsFromState" (or something similar).

@axic

axic Sep 1, 2017

Member

I'd call this "readsFromState" (or something similar).

This comment has been minimized.

@axic

axic Sep 6, 2017

Member

Sorry, I think it should go back to your original name as the other one cannot be renamed it is better to have it consistently.

@axic

axic Sep 6, 2017

Member

Sorry, I think it should go back to your original name as the other one cannot be renamed it is better to have it consistently.

return invalidInViewFunctions(_instruction);
}
bool SemanticInformation::invalidInViewFunctions(Instruction _instruction)

This comment has been minimized.

@axic

axic Sep 1, 2017

Member

I'd call this "writesToState" (or something similar).

@axic

axic Sep 1, 2017

Member

I'd call this "writesToState" (or something similar).

This comment has been minimized.

@axic

axic Sep 1, 2017

Member

Hm, probably potentiallyWritesToState given it includes jump.

@axic

axic Sep 1, 2017

Member

Hm, probably potentiallyWritesToState given it includes jump.

This comment has been minimized.

@axic

axic Sep 1, 2017

Member

Okay, I guess because of gas the current naming is better.

@axic

axic Sep 1, 2017

Member

Okay, I guess because of gas the current naming is better.

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Sep 1, 2017

Contributor

Updated.

Contributor

chriseth commented Sep 1, 2017

Updated.

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Sep 6, 2017

Member

@chriseth need to rebase

Member

axic commented Sep 6, 2017

@chriseth need to rebase

@chriseth

This comment has been minimized.

Show comment
Hide comment
@chriseth

chriseth Sep 7, 2017

Contributor

Re-running tests, but failure should be unrelated.

Contributor

chriseth commented Sep 7, 2017

Re-running tests, but failure should be unrelated.

@axic axic added the nextrelease label Sep 12, 2017

@@ -1064,6 +1064,7 @@ class MappingType: public Type
{
return _inLibrary ? shared_from_this() : TypePointer();
}
virtual bool dataStoredIn(DataLocation _location) const override { return _location == DataLocation::Storage; }

This comment has been minimized.

@axic

axic Sep 13, 2017

Member

This naming seems off since it is a bool for dataStoredInStorage.

@axic

axic Sep 13, 2017

Member

This naming seems off since it is a bool for dataStoredInStorage.

chriseth added some commits Sep 13, 2017

@chriseth chriseth merged commit 3f3bcc4 into develop Sep 13, 2017

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@axic axic deleted the checkViewPure branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment