New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function hoister #3279

Merged
merged 1 commit into from Dec 18, 2017

Conversation

Projects
None yet
4 participants
@chriseth
Contributor

chriseth commented Dec 4, 2017

No description provided.

@chriseth chriseth added the in progress label Dec 4, 2017

@chriseth chriseth referenced this pull request Dec 5, 2017

Merged

Expression Inliner #3236

{
bool topLevel = m_isTopLevel;
m_isTopLevel = false;
for (auto&& statement: _block.statements)

This comment has been minimized.

@pirapira

pirapira Dec 8, 2017

Member

Why &&? Elements of _block.statements have identities and are lvalues.

@pirapira

pirapira Dec 8, 2017

Member

Why &&? Elements of _block.statements have identities and are lvalues.

This comment has been minimized.

@chriseth

chriseth Dec 8, 2017

Contributor

Might be just a typo, but does it make a difference?

@chriseth

chriseth Dec 8, 2017

Contributor

Might be just a typo, but does it make a difference?

This comment has been minimized.

@pirapira

pirapira Dec 8, 2017

Member

I thought the C++ compilers should fail, but they don't, so I don't know.

@pirapira

pirapira Dec 8, 2017

Member

I thought the C++ compilers should fail, but they don't, so I don't know.

This comment has been minimized.

@chriseth
@chriseth

This comment has been minimized.

@pirapira

pirapira Dec 12, 2017

Member

That's weird. I'll check the spec (well, something close to it) and file a complaint.

@pirapira

pirapira Dec 12, 2017

Member

That's weird. I'll check the spec (well, something close to it) and file a complaint.

@axic

axic approved these changes Dec 18, 2017

@chriseth chriseth merged commit dbad74a into develop Dec 18, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@LianaHus LianaHus removed the in progress label Dec 18, 2017

@axic axic deleted the function_hoister branch Dec 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment