New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substitution #3287

Merged
merged 3 commits into from Dec 6, 2017

Conversation

Projects
None yet
3 participants
@chriseth
Contributor

chriseth commented Dec 5, 2017

This is a new AST tool for the optimizier. Please merge before everything else.

@chriseth chriseth requested a review from axic Dec 5, 2017

@chriseth chriseth added the in progress label Dec 5, 2017

* Specific AST copier that replaces certain identifiers with expressions.
* Only works on ASTs that are expressions.
*/
class Substitution: public ASTCopier

This comment has been minimized.

@axic

axic Dec 5, 2017

Member

Since it works on identifiers I'd call this IndentifierSubstitution.

@axic

axic Dec 5, 2017

Member

Since it works on identifiers I'd call this IndentifierSubstitution.

@pirapira

Looks good to me.

Substitutions usually substitute identifiers.

@pirapira pirapira merged commit c210943 into develop Dec 6, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@pirapira pirapira deleted the substitution branch Dec 6, 2017

@pirapira pirapira removed the in progress label Dec 6, 2017

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Dec 6, 2017

Member

Could substitute a bunch of other things here though. Since we'll have a lot of these small steps I'd prefer clear naming, which doesn't necessarily requires someone to read every header.

Member

axic commented Dec 6, 2017

Could substitute a bunch of other things here though. Since we'll have a lot of these small steps I'd prefer clear naming, which doesn't necessarily requires someone to read every header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment