Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Warn about duplicated super constructor calls #3305
I think this should be an error and not a warning given the value from the "first" (aka the inheritance definition) call is ignored.
Also it should do this check for calling the constructor twice without an argument too.
And please include a changelog entry.
referenced this pull request
Dec 19, 2017
@axic the implementation is finished but it's a breaking change (as the OpenZeppelin failure demonstrates). The change is enforced only within a contract, where it's obvious that the duplicated constructor was not intended or noticed, not across the whole inheritance graph, which would be more difficult.