New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Semantics of negation. #5087

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
3 participants
@chriseth
Contributor

chriseth commented Sep 25, 2018

Fixes #3860

@chriseth chriseth requested a review from axic Sep 25, 2018

from two's complement representation::
int x = -2**255;
assert(-x == -x);

This comment has been minimized.

@axic

axic Sep 25, 2018

Member

What exactly is this testing?

This comment has been minimized.

@bit-shift

bit-shift Sep 26, 2018

Contributor

I think it should be assert(-x == x). @chriseth ?

@axic axic added this to Inbox in 0.5.0 via automation Sep 25, 2018

@axic axic moved this from Inbox to Under review in 0.5.0 Sep 25, 2018

@codecov

This comment has been minimized.

codecov bot commented Sep 25, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (develop@f81c6e6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5087   +/-   ##
==========================================
  Coverage           ?   87.92%           
==========================================
  Files              ?      314           
  Lines              ?    31766           
  Branches           ?     3748           
==========================================
  Hits               ?    27930           
  Misses             ?     2572           
  Partials           ?     1264
Flag Coverage Δ
#all 87.92% <ø> (?)
#syntax 28.77% <ø> (?)

@chriseth chriseth force-pushed the semantics4 branch from f49cb72 to 3ba8a6e Sep 26, 2018

@axic

This comment has been minimized.

Member

axic commented Sep 26, 2018

Has a conflict now, needs a rebase :(

@chriseth chriseth force-pushed the semantics4 branch from 3ba8a6e to 7d1c428 Sep 26, 2018

@chriseth

This comment has been minimized.

Contributor

chriseth commented Sep 26, 2018

Updated.

from two's complement representation::
int x = -2**255;
assert(-x == x);

This comment has been minimized.

@axic

axic Sep 26, 2018

Member

Hm, just realised, do we have a test case for this in the EndToEnd suite?

This comment has been minimized.

@chriseth

chriseth Sep 26, 2018

Contributor

We could add it, but that's just EVM's semantics.

This comment has been minimized.

@axic

axic Sep 26, 2018

Member

Yeah but we're perhaps going to have runtime overflow checks, etc., so better to add a test case when we see it.

@axic

axic approved these changes Sep 26, 2018

@axic axic merged commit 9508406 into develop Sep 26, 2018

10 of 12 checks passed

ci/circleci: build_x86_mac Your CircleCI tests were canceled
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci: build_emscripten Your tests passed on CircleCI!
Details
ci/circleci: build_x86_linux Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: test_buglist Your tests passed on CircleCI!
Details
ci/circleci: test_check_spelling Your tests passed on CircleCI!
Details
ci/circleci: test_check_style Your tests passed on CircleCI!
Details
ci/circleci: test_emscripten_external Your tests passed on CircleCI!
Details
ci/circleci: test_emscripten_solcjs Your tests passed on CircleCI!
Details
ci/circleci: test_x86_linux Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

0.5.0 automation moved this from Under review to Done Sep 26, 2018

@axic axic deleted the semantics4 branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment