New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes mention of submodules from docs and build scripts #5215

Merged
merged 2 commits into from Oct 15, 2018

Conversation

Projects
None yet
3 participants
@Mordax
Contributor

Mordax commented Oct 14, 2018

Checklist

  • Code compiles correctly
  • [?] All tests are passing
  • README / documentation was extended, if necessary
  • [?] Changelog entry (if change is visible to the user)
  • Used meaningful commit messages

Description

Closes #5142 . Separated out create_source_tarball in separate commit just in case there's an unforseen build break.

@codecov

This comment has been minimized.

codecov bot commented Oct 14, 2018

Codecov Report

Merging #5215 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5215   +/-   ##
========================================
  Coverage    87.93%   87.93%           
========================================
  Files          315      315           
  Lines        31907    31907           
  Branches      3799     3799           
========================================
  Hits         28056    28056           
  Misses        2564     2564           
  Partials      1287     1287
Flag Coverage Δ
#all 87.93% <ø> (ø) ⬆️
#syntax 28.39% <ø> (ø) ⬆️
@ChrisChinchilla

This comment has been minimized.

Contributor

ChrisChinchilla commented Oct 15, 2018

From a docs perspective this looks fine to me.

@chriseth chriseth merged commit 5a921c4 into ethereum:develop Oct 15, 2018

17 checks passed

ci/circleci: build_emscripten Your tests passed on CircleCI!
Details
ci/circleci: build_x86_linux Your tests passed on CircleCI!
Details
ci/circleci: build_x86_mac Your tests passed on CircleCI!
Details
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: test_buglist Your tests passed on CircleCI!
Details
ci/circleci: test_check_spelling Your tests passed on CircleCI!
Details
ci/circleci: test_check_style Your tests passed on CircleCI!
Details
ci/circleci: test_emscripten_external Your tests passed on CircleCI!
Details
ci/circleci: test_emscripten_solcjs Your tests passed on CircleCI!
Details
ci/circleci: test_x86_linux Your tests passed on CircleCI!
Details
ci/circleci: test_x86_mac Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 26dc876...40b9b52
Details
codecov/project 85.49% remains the same compared to 26dc876
Details
codecov/project/syntax 83.85% remains the same compared to 26dc876
Details
codecov/project/tests 93.3% remains the same compared to 26dc876
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment