New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage change tests #483

Closed
chfast opened this Issue Aug 8, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@chfast
Copy link
Contributor

chfast commented Aug 8, 2018

In preparation for EIP-1087.

For a single SSTORE of a given key, we have following cases:

  • z: 0 -> 0 (zero),
  • a: 0 -> X (added),
  • d: X -> 0 (deleted),
  • m: X -> Y (modified).
  • u: X -> X (unchanged).

Make sure we have proper tests for all cases (probably yes).

Now let's create a set of test cases where we combine each possibility into sequence of two SSTORES:

  • zz: 0 -> 0 -> 0
  • za: 0 -> 0 -> X
  • ad: 0 -> X -> 0
  • am: 0 -> X -> Y
  • au: 0 -> X -> X
  • dz: X -> 0 -> 0
  • da: X -> 0 -> X
  • da2: X -> 0 -> Y
  • md: X -> Y -> 0
  • mm: X -> Y -> Z
  • mm2: X -> Y -> X
  • mu: X -> Y -> Y
  • ud: X -> X -> 0
  • um: X -> X -> Y
  • uu: X -> X -> X
@winsvega

This comment has been minimized.

@sorpaas

This comment has been minimized.

Copy link

sorpaas commented Aug 24, 2018

Two additional test cases for reset and set again:

  • ada: 0 -> X -> 0 -> X
  • dad: X -> 0 -> X -> 0
@chfast

This comment has been minimized.

Copy link
Contributor Author

chfast commented Oct 8, 2018

Can this be closed now?

@winsvega

This comment has been minimized.

Copy link
Collaborator

winsvega commented Oct 8, 2018

No. The cases have not been added to the repo yet.
In fact tests not written yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment