Skip to content

/trinity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trinity is not 100% Istanbul-ready due to bug in current py-evm version #1312

Closed
veox opened this issue Nov 21, 2019 · 1 comment
Closed

Trinity is not 100% Istanbul-ready due to bug in current py-evm version #1312

veox opened this issue Nov 21, 2019 · 1 comment

Comments

@veox
Copy link
Contributor

@veox veox commented Nov 21, 2019 •
edited

What is wrong?

py-evm had a stray change, a difficulty bomb delay that didn't actually go into Istanbul. The fix has been applied, but is not yet in a tagged py-evm release, and so isn't in Trinity.

Come Istanbul, Trinity will apply the bomb delay, and start miscalculating block difficulty.

How can it be fixed

Pin to the fixed version of py-evm when it is released, and make a new Trinity release.
@veox

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@veox veox commented Dec 2, 2019 •
edited

py-evm 0.3.0-alpha.9 has the fix:

https://py-evm.readthedocs.io/en/latest/release_notes.html#py-evm-0-3-0-alpha-9-2019-12-02
@carver carver mentioned this issue Dec 4, 2019
Merged
2 of 2 tasks complete
@carver carver closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@veox @carver
You can’t perform that action at this time.