Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid use_develop option for wheel-cli tests #1470

Merged
merged 2 commits into from Jan 11, 2020

Conversation

@kclowes
Copy link
Contributor

kclowes commented Jan 10, 2020

What was wrong?

When I was updating the web3 script that I stole to do the same thing, I noticed tox doesn't have a use_develop configuration flag. The actual flag doesn't have an underscore (usedevelop) and it's default is false anyway, so I don't think you need it. Docs here :)

How was it fixed?

Removed it!

To-Do

  • Clean up commit history
  • Add entry to the release notes
  • Probably doesn't deserve a newsfragment, but let me know if you feel differently!

Cute Animal Picture

image

@kclowes

This comment has been minimized.

Copy link
Contributor Author

kclowes commented Jan 10, 2020

I think the failing test is flaky because the py37-wheel-cli passed but if I just made it flaky, let me know. For some reason circle won't let me re-run the workflow ¯_(ツ)_/¯

@@ -109,14 +109,12 @@ deps = {[common-wheel-cli]deps}
whitelist_externals = {[common-wheel-cli]whitelist_externals}
commands = {[common-wheel-cli]commands}
skip_install=true
use_develop=false

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Jan 10, 2020

Member

Looking under the main [testenv] we do indeed have usedevelop=True there. What I'm unsure about is whether we need it here as it isn't clear whether this environment inherits that setting (I am inclined to think that it does)...

This comment has been minimized.

Copy link
@kclowes

kclowes Jan 10, 2020

Author Contributor

ohh, shoot. Didn't check that. I'm pretty sure it inherits too. I'll update to usedevelop.

@kclowes

This comment has been minimized.

Copy link
Contributor Author

kclowes commented Jan 10, 2020

@pipermerriam I am not sure why the 3.7 test is passing while the 3.6 test isn't. Also, looks like there are different failures, depending on the run. It looks like test_shutdown_does_not_throw_errors is pretty consistently XPASSing, but I'm seeing failures sometimes on test_does_not_throw_errors_on_short_run and other times on test_web3_commands_via_attached_console. If you don't have any ideas off the top of your head, I may close this PR and raise an issue instead, since I don't think this is very high priority for anyone.

@pipermerriam

This comment has been minimized.

Copy link
Member

pipermerriam commented Jan 10, 2020

our wheel tests are flaky so I typically just re-run them unless they are both failing.

@pipermerriam pipermerriam merged commit 3ea8007 into ethereum:master Jan 11, 2020
44 checks passed
44 checks passed
ci/circleci: docker-trinity-beacon-image-build-test Your tests passed on CircleCI!
Details
ci/circleci: docker-trinity-image-build-test Your tests passed on CircleCI!
Details
ci/circleci: py36-docs Your tests passed on CircleCI!
Details
ci/circleci: py36-eth1-components Your tests passed on CircleCI!
Details
ci/circleci: py36-eth1-core Your tests passed on CircleCI!
Details
ci/circleci: py36-eth1-monitor-trio Your tests passed on CircleCI!
Details
ci/circleci: py36-eth2-core Your tests passed on CircleCI!
Details
ci/circleci: py36-eth2-fixtures Your tests passed on CircleCI!
Details
ci/circleci: py36-eth2-integration Your tests passed on CircleCI!
Details
ci/circleci: py36-eth2-utils Your tests passed on CircleCI!
Details
ci/circleci: py36-integration Your tests passed on CircleCI!
Details
ci/circleci: py36-lightchain_integration Your tests passed on CircleCI!
Details
ci/circleci: py36-lint Your tests passed on CircleCI!
Details
ci/circleci: py36-lint-eth2 Your tests passed on CircleCI!
Details
ci/circleci: py36-long_run_integration Your tests passed on CircleCI!
Details
ci/circleci: py36-p2p Your tests passed on CircleCI!
Details
ci/circleci: py36-p2p-trio Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-blockchain Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-state-byzantium Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-state-constantinople Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-state-frontier Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-state-homestead Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-state-petersburg Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-state-spurious_dragon Your tests passed on CircleCI!
Details
ci/circleci: py36-rpc-state-tangerine_whistle Your tests passed on CircleCI!
Details
ci/circleci: py36-wheel-cli Your tests passed on CircleCI!
Details
ci/circleci: py37-eth1-components Your tests passed on CircleCI!
Details
ci/circleci: py37-eth1-core Your tests passed on CircleCI!
Details
ci/circleci: py37-eth1-monitor-trio Your tests passed on CircleCI!
Details
ci/circleci: py37-eth2-components Your tests passed on CircleCI!
Details
ci/circleci: py37-eth2-core Your tests passed on CircleCI!
Details
ci/circleci: py37-eth2-fixtures Your tests passed on CircleCI!
Details
ci/circleci: py37-eth2-integration Your tests passed on CircleCI!
Details
ci/circleci: py37-eth2-utils Your tests passed on CircleCI!
Details
ci/circleci: py37-libp2p Your tests passed on CircleCI!
Details
ci/circleci: py37-lint Your tests passed on CircleCI!
Details
ci/circleci: py37-lint-eth2 Your tests passed on CircleCI!
Details
ci/circleci: py37-p2p Your tests passed on CircleCI!
Details
ci/circleci: py37-p2p-trio Your tests passed on CircleCI!
Details
ci/circleci: py37-rpc-state-quadratic Your tests passed on CircleCI!
Details
ci/circleci: py37-rpc-state-sstore Your tests passed on CircleCI!
Details
ci/circleci: py37-rpc-state-zero_knowledge Your tests passed on CircleCI!
Details
ci/circleci: py37-wheel-cli Your tests passed on CircleCI!
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.