Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add external contract calling functionality #335
- What I did
I added the ability to call external contracts in response to #297.
- How I did it
I did this by allowing existing contracts to be referenced using:
To understand the formatting further look in my
- How to verify it
I added tests in
- Description for the changelog
Add external contract calling functionality
- Cute Animal Picture
I would like to see these tests in their own file. This is large feature and is going to need lots more through testing.
Additionally, I would like to see this feature morph into a type instead (e.g.
foo: external or
foo: contract, then list expected method type signatures), but this works for now.
@fubuloubu I broke the tests out into a separate file and added the additional tests you suggested. I'd like to implement the contract data type functionality we talked about in another PR to make it easier to review.
@JackieXu I fixed the test I broke in
If either of you see any other tests that should be made or better ways to do things please let me know.